Paths

Table of Contentst

pciconf: Add -C option to filter by class name
Needs ReviewPublic
Actions

Authored by code_fedang.net on Fri, Sep 11, 10:16 PM.

Tags

None

Referenced Files

	F172329527: D59602.diff
	Thu, Sep 17, 6:52 PM

	F172278553: D59602.id.diff
	Thu, Sep 17, 10:40 AM

	Unknown Object (File)
	Wed, Sep 16, 1:43 PM

	Unknown Object (File)
	Wed, Sep 16, 10:17 AM

	Unknown Object (File)
	Tue, Sep 15, 10:34 PM

	Unknown Object (File)
	Tue, Sep 15, 8:37 PM

	Unknown Object (File)
	Tue, Sep 15, 3:41 PM

	Unknown Object (File)
	Mon, Sep 14, 6:33 AM

View All 21 Files

Subscribers

imp

ziaee

Details

Reviewers

bnovkov

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76786
Build 73669: arc lint + arc unit

Event Timeline

code_fedang.net created this revision.Fri, Sep 11, 10:16 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Sep 11, 10:16 PM

code_fedang.net requested review of this revision.Fri, Sep 11, 10:16 PM

Harbormaster completed remote builds in B76785: Diff 186493.Fri, Sep 11, 10:16 PM

Use strcasecmp instead of strcmp to check class name.

Harbormaster completed remote builds in B76786: Diff 186494.Fri, Sep 11, 10:27 PM

Addresses Bug 289923

bnovkov added inline comments.Mon, Sep 14, 4:44 PM

usr.sbin/pciconf/pciconf.8
26	Please bump the date.
usr.sbin/pciconf/pciconf.c
1094	This function should ideally return a `bool`.
1097
1100	Please turn this into an explicit `== 0` check
1101–1104

Address comment

Harbormaster completed remote builds in B76936: Diff 186782.Tue, Sep 15, 3:46 PM

code_fedang.net marked 5 inline comments as done.Tue, Sep 15, 4:18 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

pciconf/

pciconf.8

8 lines

pciconf.c

40 lines

Diff 186494

View Options

usr.sbin/pciconf/pciconf.8