Page MenuHomeFreeBSD
Differential D59680

mlx4: convert to timer_setup() LinuxKPI
ClosedPublic
Actions

Authored by bz on Mon, Sep 14, 10:54 PM.
Tags
None
Referenced Files
F173065531: D59680.id186733.diff
Wed, Sep 23, 7:47 AM
F173040184: D59680.id.diff
Wed, Sep 23, 2:28 AM
F172991899: D59680.id186997.diff
Tue, Sep 22, 5:05 PM
Unknown Object (File)
Tue, Sep 22, 8:44 AM
Unknown Object (File)
Mon, Sep 21, 1:53 PM
Unknown Object (File)
Mon, Sep 21, 8:54 AM
Unknown Object (File)
Mon, Sep 21, 7:40 AM
Unknown Object (File)
Sun, Sep 20, 2:50 PM
View All 20 Files
Subscribers
imp
linuxkpi

Details

Reviewers
kib
Commits
rGe03abec93cf8: mlx4: convert to timer_setup() Linux KPI
rG871c09c9b47e: mlx4: convert to timer_setup() Linux KPI
Summary

The Linux driver switched away from using this timer in e22979d96a55d.
Locally adjust the code to use timer_setup/from_timer in order to get
us out of Linux version 4.15 (and earlier) KPIs.

MFC after: 3 days

Test Plan

Please add others to the review as you see fit.
I CANNOT TEST THIS.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 76906
Build 73789: arc lint + arc unit

Event Timeline

bz created this revision.Mon, Sep 14, 10:54 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Sep 14, 10:54 PM
bz requested review of this revision.Mon, Sep 14, 10:54 PM
Harbormaster completed remote builds in B76903: Diff 186733.Mon, Sep 14, 10:55 PM
bz added a parent revision: D58834: LinuxKPI: rework struct timer_list (*function[_415]).Mon, Sep 14, 10:55 PM
bz added inline comments.Mon, Sep 14, 11:10 PM
sys/dev/mlx4/mlx4_en/mlx4_en_tx.c
438

Switch to timer_container_of() right away.

bz updated this revision to Diff 186736.Tue, Sep 15, 12:00 AM

Also apply 41cb08555c416 from_timer -> timer_container_of.

Harbormaster completed remote builds in B76906: Diff 186736.Tue, Sep 15, 12:00 AM
bz added a child revision: D59688: LinuxKPI: remove timer KPI from Linux version before 4.15.Tue, Sep 15, 1:35 AM
kib accepted this revision.Tue, Sep 15, 5:29 AM

Nvidia cannot test this either. Consider my review as just a fellow committer looking at the same code.

This revision is now accepted and ready to land.Tue, Sep 15, 5:29 AM
bz added a comment.Tue, Sep 15, 6:15 AM
In D59680#1369793, @kib wrote:

Nvidia cannot test this either. Consider my review as just a fellow committer looking at the same code.

Thanks a lot! I guess time will tell :)

Closed by commit rG871c09c9b47e: mlx4: convert to timer_setup() Linux KPI (authored by bz). · Explain WhyThu, Sep 17, 9:16 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG871c09c9b47e: mlx4: convert to timer_setup() Linux KPI.
bz added a commit: rGe03abec93cf8: mlx4: convert to timer_setup() Linux KPI.Sat, Sep 19, 2:40 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
mlx4/
mlx4_en/
2 lines
4 lines
4 lines

Diff 186736

View Options

sys/dev/mlx4/mlx4_en/en.h

Loading...
View Options

sys/dev/mlx4/mlx4_en/mlx4_en_cq.c

Loading...
View Options

sys/dev/mlx4/mlx4_en/mlx4_en_tx.c

Loading...