Page MenuHomeFreeBSD

Allwinner MMC cleanup
ClosedPublic

Authored by manu on Jun 16 2016, 4:36 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Jan 3, 1:11 AM
Unknown Object (File)
Dec 10 2024, 3:05 PM
Unknown Object (File)
Dec 9 2024, 12:53 AM
Unknown Object (File)
Dec 1 2024, 8:08 AM
Unknown Object (File)
Nov 30 2024, 7:31 AM
Unknown Object (File)
Nov 30 2024, 6:57 AM
Unknown Object (File)
Nov 26 2024, 10:58 AM
Unknown Object (File)
Nov 13 2024, 4:32 PM

Details

Summary

Rename a10_mmc to aw_mmc to avoid confusion.
Remove pio code.
Remove check on id.

Test Plan

Tested on olimex-a20-som-evb

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4570
Build 4622: arc lint + arc unit

Event Timeline

manu retitled this revision from to Allwinner MMC cleanup.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added a reviewer: ARM.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.

My board died after a few minutes, so it need more work.

Rename all register as in the datasheet.
Remove completely the PIO code.
Set number of dma segments to (MAXPHYS / PAGE_SIZE) + 1
File will be move to aw_mmc.{c,h} but here is easier to see the changes.

Do not rename a10_mmc for now as it's easier to see changes.

Do an hardware reset a attach (undocumented register).
Only update clock if needed.
Always set bus width before updating clock.

Tested on A20 and H3

sys/arm/allwinner/a10_mmc.c
744

should this be renamed to ckcr to match the new register name?

sys/arm/allwinner/a10_mmc.c
744

Totally, I'll do a re-read of the code to check if all the variable name are consistent with the registers ones.

Rename variable from clkcr to ckcr to reflect register name.

This revision is now accepted and ready to land.Aug 27 2016, 10:57 AM
This revision was automatically updated to reflect the committed changes.