Page MenuHomeFreeBSD
Differential D6868

Allwinner MMC cleanup
ClosedPublic
Actions

Authored by manu on Jun 16 2016, 4:36 PM.
Tags
Referenced Files
Unknown Object (File)
Tue, Nov 26, 10:58 AM
Unknown Object (File)
Wed, Nov 13, 4:32 PM
Unknown Object (File)
Oct 21 2024, 8:06 AM
Unknown Object (File)
Oct 16 2024, 7:49 PM
Unknown Object (File)
Oct 7 2024, 11:24 AM
Unknown Object (File)
Oct 4 2024, 4:30 AM
Unknown Object (File)
Oct 1 2024, 10:26 AM
Unknown Object (File)
Oct 1 2024, 5:39 AM
View All Files
Subscribers
andrew
imp
jmcneill

Details

Reviewers
jmcneill
Group Reviewers
ARM
Commits
rS308280: MFC r305689:
rS305689: a10_mmc: Remove completly the PIO code now all access is done by DMA.
Summary

Rename a10_mmc to aw_mmc to avoid confusion.
Remove pio code.
Remove check on id.

Test Plan

Tested on olimex-a20-som-evb

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4833
Build 4894: arc lint + arc unit

Event Timeline

manu updated this revision to Diff 17635.Jun 16 2016, 4:36 PM
manu retitled this revision from to Allwinner MMC cleanup.
manu updated this object.
manu edited the test plan for this revision. (Show Details)
manu added a reviewer: ARM.
manu set the repository for this revision to rS FreeBSD src repository - subversion.
manu added a project: ARM.
Herald added subscribers: andrew, imp. · View Herald TranscriptJun 16 2016, 4:36 PM
manu added a comment.Jun 16 2016, 4:41 PM

My board died after a few minutes, so it need more work.

manu updated this revision to Diff 18666.Jul 22 2016, 2:35 PM

Rename all register as in the datasheet.
Remove completely the PIO code.
Set number of dma segments to (MAXPHYS / PAGE_SIZE) + 1
File will be move to aw_mmc.{c,h} but here is easier to see the changes.

andrew added a comment.Jul 29 2016, 11:57 AM

Is this stable now?

manu added a subscriber: jmcneill.Jul 29 2016, 12:37 PM

Yes, I'm waiting on @jmcneill to see if he can reproduce https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207621 with this patch.

manu updated this revision to Diff 19017.Aug 3 2016, 7:05 PM

Do not rename a10_mmc for now as it's easier to see changes.

manu updated this revision to Diff 19407.Aug 17 2016, 11:55 AM

Do an hardware reset a attach (undocumented register).
Only update clock if needed.
Always set bus width before updating clock.

Tested on A20 and H3

imp added inline comments.Aug 17 2016, 5:42 PM
sys/arm/allwinner/a10_mmc.c
748

should this be renamed to ckcr to match the new register name?

manu added inline comments.Aug 17 2016, 6:01 PM
sys/arm/allwinner/a10_mmc.c
748

Totally, I'll do a re-read of the code to check if all the variable name are consistent with the registers ones.

manu updated this revision to Diff 19494.Aug 19 2016, 3:56 PM

Rename variable from clkcr to ckcr to reflect register name.

jmcneill accepted this revision.Aug 27 2016, 10:57 AM
jmcneill added a reviewer: jmcneill.
This revision is now accepted and ready to land.Aug 27 2016, 10:57 AM
Closed by commit rS305689: a10_mmc: Remove completly the PIO code now all access is done by DMA. (authored by manu). · Explain WhySep 10 2016, 5:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
arm/
allwinner/
258 lines
296 lines

Diff 19407

View Options

sys/arm/allwinner/a10_mmc.h

Loading...
View Options

sys/arm/allwinner/a10_mmc.c

Loading...