graid3: Restore lock acquisition
ClosedPublic
Actions

Authored by des on Sep 10 2026, 9:37 AM.

Details

Reviewers

pjd
delphij
kevans

Commits

rG0b7215cfa262: graid3: Restore lock acquisition
rG89cbf4bc875f: graid3: Restore lock acquisition
rG9094f86b57a7: graid3: Restore lock acquisition

Summary

The lock acquisition in g_raid3_ctl_insert() was improperly dropped a
while ago, making it impossible to add or replace a device in an
existing graid3. This went unnoticed because the tests are broken.

MFC after: 1 week
Fixes: fcf69f3dbce6 ("Consistently use gctl_get_provider instead of home-grown variants.")
Event: EuroBSDcon DevSummit 2026

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Sep 10 2026, 9:37 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 10 2026, 9:37 AM

des requested review of this revision.Sep 10 2026, 9:37 AM

Harbormaster completed remote builds in B76735: Diff 186356.Sep 10 2026, 9:37 AM

des added a child revision: D59564: tests: Fix graid3 insert tests.Sep 10 2026, 9:38 AM

delphij accepted this revision.Thu, Sep 10, 6:44 PM

This revision is now accepted and ready to land.Thu, Sep 10, 6:44 PM

Closed by commit rG9094f86b57a7: graid3: Restore lock acquisition (authored by des). · Explain WhySun, Sep 13, 12:32 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG9094f86b57a7: graid3: Restore lock acquisition.

des added a commit: rG89cbf4bc875f: graid3: Restore lock acquisition.Sun, Sep 20, 5:08 PM

des added a commit: rG0b7215cfa262: graid3: Restore lock acquisition.

Revision Contents
Changeset List

Path

Size

sys/

geom/

raid3/

g_raid3_ctl.c

1 line

Diff 186590

View Options

sys/geom/raid3/g_raid3_ctl.c

graid3: Restore lock acquisitionClosedPublicActions