aq(4): arm PHY thermal shutdown from the admin poll
ClosedPublic
Actions

Authored by nick_spun.io on Fri, Sep 11, 3:16 PM.

Details

Reviewers

adrian
emaste

Commits

rG75a1939f6360: aq(4): arm PHY thermal shutdown from the admin poll

Summary

move thermal shutdown arming to the admin poll

this gives a more reasonable delay prior to the first attempt, and also
allows us to retry and make the option runtime-tuneable via a new
disable_thermal_arm sysctl

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76778
Build 73661: arc lint + arc unit

Event Timeline

nick_spun.io created this revision.Fri, Sep 11, 3:16 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Sep 11, 3:16 PM

nick_spun.io requested review of this revision.Fri, Sep 11, 3:16 PM

Harbormaster completed remote builds in B76778: Diff 186470.Fri, Sep 11, 3:16 PM

nick_spun.io added reviewers: adrian, emaste.Fri, Sep 11, 3:17 PM

nick_spun.io added a project: drivers.

As a general rule I prefer positive-sense controls - so e.g. "enable_thermal_limit" or "thermal_limit.enable" (if we're also going to have a "thermal_limit.count or such), and it can default to true.

share/man/man4/aq.4
177	At first I read this as the driver applies the setting, which restores the firmware's own default -- it's the reset of the adapter which restored the firmware's own default, and we're overriding that, right? For the purpose of the user-facing man page I think we could just leave the note about firmware defaults out.

In D59593#1367454, @emaste wrote:

As a general rule I prefer positive-sense controls - so e.g. "enable_thermal_limit" or "thermal_limit.enable" (if we're also going to have a "thermal_limit.count or such), and it can default to true.

Can do - the A1 cards disable it by default and the A2 cards enable it by default so we're overriding one of them either way

invert knob and add parent thermal node, clean up verbiage in man page

Harbormaster completed remote builds in B76779: Diff 186472.Fri, Sep 11, 4:14 PM

nick_spun.io marked an inline comment as done.Fri, Sep 11, 4:15 PM

adrian accepted this revision.Fri, Sep 11, 4:26 PM

This revision is now accepted and ready to land.Fri, Sep 11, 4:26 PM

Closed by commit rG75a1939f6360: aq(4): arm PHY thermal shutdown from the admin poll (authored by • nprice). · Explain WhySat, Sep 12, 10:20 PM

This revision was automatically updated to reflect the committed changes.

• nprice added a commit: rG75a1939f6360: aq(4): arm PHY thermal shutdown from the admin poll.