acpi_spmc: Check Intel constraint packages
ClosedPublic
Actions

Authored by obiwac on Thu, Sep 10, 9:47 AM.

Details

Reviewers

olce

Commits

rG508efe35e577: acpi_spmc: Check Intel constraint packages

Summary

Some firmware inexplicably decides to do non-standard and annoying stuff
here, e.g. the Fujitsu Futro S940 with an Intel Pentium J5005 sometimes
returns the following when calling the DEVICE_CONSTRAINTS function on
the Intel DSM:

Return (Package (0x01)
{
    Zero
})

(Package elements here are supposed to be constraint packages, not just a
single value.)

First reported in the following forum post:

https://forum.netgate.com/topic/201090/2.9.0-beta-leads-to-kernel-panic-on-boot

Reported by: TampertK on forum.netgate.com
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76738
Build 73621: arc lint + arc unit

Event Timeline

obiwac created this revision.Thu, Sep 10, 9:47 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, Sep 10, 9:47 AM

obiwac requested review of this revision.Thu, Sep 10, 9:47 AM

Harbormaster completed remote builds in B76738: Diff 186360.Thu, Sep 10, 9:47 AM

obiwac added a parent revision: D59562: acpi_spmc: Make sure constraints array doesn't end up sparse.Thu, Sep 10, 9:47 AM

oops forgot continue

Harbormaster completed remote builds in B76739: Diff 186364.Thu, Sep 10, 9:54 AM

Move name dup later so no leak if skipped constraint

Harbormaster completed remote builds in B76742: Diff 186375.Thu, Sep 10, 12:07 PM

obiwac mentioned this in D59568: acpi_spmc: Check AMD constraint packages.Thu, Sep 10, 12:10 PM

obiwac added a child revision: D59568: acpi_spmc: Check AMD constraint packages.Thu, Sep 10, 12:12 PM

That's certainly good enough. We can add even more checks later.

This revision is now accepted and ready to land.Fri, Sep 11, 4:00 PM

By the way, could you perhaps move all reads to constraint_obj->Package.Elements[] together close to the package size check? That makes it easier to verify that the check is correct.

Closed by commit rG508efe35e577: acpi_spmc: Check Intel constraint packages (authored by obiwac). · Explain WhySat, Sep 12, 11:35 AM

This revision was automatically updated to reflect the committed changes.

obiwac added a commit: rG508efe35e577: acpi_spmc: Check Intel constraint packages.