acpi_spmc: Make sure constraints array doesn't end up sparse
ClosedPublic
Actions

Authored by obiwac on Thu, Sep 10, 9:37 AM.

Tags

None

Referenced Files

	F171674828: D59562.id186355.diff
	Sat, Sep 12, 2:44 PM

	F171663999: D59562.diff
	Sat, Sep 12, 12:55 PM

	F171660661: D59562.diff
	Sat, Sep 12, 12:24 PM

	F171642246: D59562.id186355.diff
	Sat, Sep 12, 9:28 AM

	Unknown Object (File)
	Fri, Sep 11, 11:57 AM

	Unknown Object (File)
	Thu, Sep 10, 8:26 PM

	Unknown Object (File)
	Thu, Sep 10, 8:25 PM

	Unknown Object (File)
	Thu, Sep 10, 8:23 PM

View All 10 Files

Subscribers

imp

Details

Reviewers

olce

Commits

rG542df51903ae: acpi_spmc: Make sure constraints array doesn't end up sparse

Summary

If we skip one of the constraint package elements and decrement
sc->constraint_count, sc->constraints would end up sparse and some of
our constraints would be put aftre sc->constraint_count.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

obiwac created this revision.Thu, Sep 10, 9:37 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, Sep 10, 9:37 AM

obiwac requested review of this revision.Thu, Sep 10, 9:37 AM

Harbormaster completed remote builds in B76734: Diff 186355.Thu, Sep 10, 9:37 AM

obiwac added a child revision: D59566: acpi_spmc: Check Intel constraint packages.Thu, Sep 10, 9:47 AM

olce accepted this revision.Thu, Sep 10, 3:43 PM

This revision is now accepted and ready to land.Thu, Sep 10, 3:43 PM

Closed by commit rG542df51903ae: acpi_spmc: Make sure constraints array doesn't end up sparse (authored by obiwac). · Explain WhyThu, Sep 10, 8:58 PM

This revision was automatically updated to reflect the committed changes.

obiwac added a commit: rG542df51903ae: acpi_spmc: Make sure constraints array doesn't end up sparse.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi_spmc.c

6 lines

Diff 186414

View Options

sys/dev/acpica/acpi_spmc.c

acpi_spmc: Make sure constraints array doesn't end up sparseClosedPublicActions