Differential D59468

vp_crossmp: weaken the assert and make it more precise
ClosedPublic
Actions

Authored by kib on Sun, Sep 6, 8:57 PM.

Tags

None

Referenced Files

	F171044964: D59468.diff
	Tue, Sep 8, 9:14 AM

	F170913753: D59468.diff
	Mon, Sep 7, 1:19 PM

	Unknown Object (File)
	Mon, Sep 7, 5:56 AM

	Unknown Object (File)
	Mon, Sep 7, 5:55 AM

	Unknown Object (File)
	Mon, Sep 7, 2:56 AM

Subscribers

Details

Reviewers

markj
jah

Commits

rGc63c77b3a531: vp_crossmp: weaken the assert and make it more precise

Summary

Since the vp_crossmp vnode can leak into vn_vptocnp() calls due to
nullfs file mounting, not all lock requests are non-sleeping. The
requirement for the crossmp locking is that all lock requests should be
shared. Then, it does not matter if the requests allow sleeping, since
all locks are shared.

Also, check the lock type by correctly masking it with LK_TYPE_MASK.

Reported and tested by: pho

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sun, Sep 6, 8:57 PM

Herald added subscribers: olce, imp. · View Herald TranscriptSun, Sep 6, 8:57 PM

kib requested review of this revision.Sun, Sep 6, 8:57 PM

jah accepted this revision.Mon, Sep 7, 5:43 AM

This revision is now accepted and ready to land.Mon, Sep 7, 5:43 AM

markj accepted this revision.Mon, Sep 7, 1:19 PM

Closed by commit rGc63c77b3a531: vp_crossmp: weaken the assert and make it more precise (authored by kib). · Explain WhyMon, Sep 7, 3:48 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGc63c77b3a531: vp_crossmp: weaken the assert and make it more precise.

Revision Contents
Changeset List

Path

Size

sys/

kern/

2 lines

Diff 186130

sys/kern/vfs_lookup.c

Loading...