Page MenuHomeFreeBSD
Differential D58872

apple_bce: initiate IN data phase for control transfers
ClosedPublic
Actions

Authored by seuros on Sun, Aug 16, 7:50 PM.
Tags
None
Referenced Files
F170968804: D58872.id186013.diff
Mon, Sep 7, 10:22 PM
Unknown Object (File)
Fri, Sep 4, 9:55 PM
Unknown Object (File)
Fri, Sep 4, 6:42 PM
Unknown Object (File)
Thu, Sep 3, 4:44 PM
Unknown Object (File)
Wed, Sep 2, 1:42 PM
Unknown Object (File)
Tue, Sep 1, 4:45 PM
Unknown Object (File)
Mon, Aug 31, 4:47 PM
Unknown Object (File)
Mon, Aug 31, 10:28 AM
View All 24 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rGe8018942942e: apple_bce: initiate IN data phase for control transfers
Summary

For IN control transfers, the firmware does
not send TRANSFER_REQUEST for the data phase
the host must send BCE_VHCI_CMD_TRANSFER_REQUEST
with an IN DMA buffer once the setup phase completes.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 76595
Build 73478: arc lint + arc unit

Event Timeline

seuros created this revision.Sun, Aug 16, 7:50 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Aug 16, 7:50 PM
seuros requested review of this revision.Sun, Aug 16, 7:50 PM
Harbormaster completed remote builds in B75627: Diff 184138.Sun, Aug 16, 7:50 PM
seuros added a child revision: D58873: apple_bce: ignore duplicate TRANSFER_REQUEST in STATUS state.Sun, Aug 16, 7:55 PM
seuros added a parent revision: D58871: apple_bce: fix cold boot panic in mailbox send.
adrian added inline comments.Sun, Sep 6, 5:18 PM
sys/dev/apple_bce/apple_bce_vhci.c
1843

This whole if branch looks big enough to stick in its own private function. Wanna go do that?

seuros updated this revision to Diff 186013.Sun, Sep 6, 6:30 PM

refactor spaghetti code into function.

Harbormaster completed remote builds in B76595: Diff 186013.Sun, Sep 6, 6:30 PM
adrian accepted this revision.Sun, Sep 6, 7:38 PM
This revision is now accepted and ready to land.Sun, Sep 6, 7:38 PM
Closed by commit rGe8018942942e: apple_bce: initiate IN data phase for control transfers (authored by seuros). · Explain WhySun, Sep 6, 7:48 PM
This revision was automatically updated to reflect the committed changes.
seuros added a commit: rGe8018942942e: apple_bce: initiate IN data phase for control transfers.

Revision Contents
Changeset List

PathSize
sys/
dev/
apple_bce/
70 lines

Diff 186013

View Options

sys/dev/apple_bce/apple_bce_vhci.c

Loading...