various: Fix nlist invocations
Needs ReviewPublic
Actions

Authored by des on Fri, Aug 28, 7:07 PM.

Details

Reviewers

jhb
kib

Summary

Fix nlist(3) consumers that either expected our toolchain to prepend an
underscore to symbol names or expected nlist(3) to ignore the mismatch,
as it did until we overhauled it back in May.

While here, also fix cases where the last element in the list had an
empty string instead of NULL as sentinel.

Fixes: 4617a6cb82a6 ("nlist: Handle multiple symbol tables")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76282
Build 73165: arc lint + arc unit

Event Timeline

des created this revision.Fri, Aug 28, 7:07 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 28, 7:07 PM

des requested review of this revision.Fri, Aug 28, 7:07 PM

Harbormaster completed remote builds in B76282: Diff 185363.Fri, Aug 28, 7:07 PM

des added a child revision: D59255: vmstat: Drop vm_cnt compat hack.Fri, Aug 28, 7:07 PM

kib accepted this revision.Sat, Aug 29, 3:29 AM

This revision is now accepted and ready to land.Sat, Aug 29, 3:29 AM

This is still missing usr.bin/ktrdump/ktrdump.c, tools/tools/ifpifa/ifpifa.c, and tools/tools/umastat/umastat.c from my initial list. I haven't checked for any others (and you've found a few I had missed).

usr.bin/netstat/nlist_symbols
3	Good catch

In D59254#1359587, @jhb wrote:

This is still missing usr.bin/ktrdump/ktrdump.c, tools/tools/ifpifa/ifpifa.c, and tools/tools/umastat/umastat.c from my initial list. I haven't checked for any others (and you've found a few I had missed).

I forgot to git add the first, and deliberately skipped the other two as “not my problem”.