Page MenuHomeFreeBSD
Differential D59144

install: Fix two bugs in stdin code
ClosedPublic
Actions

Authored by des on Mon, Aug 24, 2:00 PM.
Tags
None
Referenced Files
F172601576: D59144.id185092.diff
Sat, Sep 19, 2:51 PM
Unknown Object (File)
Thu, Sep 17, 6:48 AM
Unknown Object (File)
Wed, Sep 16, 6:46 AM
Unknown Object (File)
Tue, Sep 15, 10:46 PM
Unknown Object (File)
Tue, Sep 15, 9:57 PM
Unknown Object (File)
Tue, Sep 15, 9:26 PM
Unknown Object (File)
Tue, Sep 15, 4:12 AM
Unknown Object (File)
Tue, Sep 15, 4:06 AM
View All 87 Files
Subscribers
imp

Details

Reviewers
siva
markj
Commits
rG5805e0ec8872: install: Fix two bugs in stdin code
rG203438d0a38c: install: Fix two bugs in stdin code
rG724c344aeded: install: Fix two bugs in stdin code
rGa5ff4125cf08: install: Fix two bugs in stdin code
Summary
  • Fix case where the source is - and the target exists.
  • Only call chflags() (to remove flags that might prevent us from replacing an existing target) in the exists case; otherwise, to_sb.st_flags is uninitialized.
  • Rename the source file in the stdin test case.
  • Extend null and stdin test cases to cover the case where the target already exists.

PR: 297681
MFC after: 1 week
Fixes: d34870708db9 ("install: Allow installing stdin")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Mon, Aug 24, 2:00 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, Aug 24, 2:00 PM
des requested review of this revision.Mon, Aug 24, 2:00 PM
Harbormaster completed remote builds in B76049: Diff 184885.Mon, Aug 24, 2:00 PM
des edited the summary of this revision. (Show Details)Mon, Aug 24, 2:16 PM
des updated this revision to Diff 184886.Mon, Aug 24, 2:17 PM
des edited the summary of this revision. (Show Details)

update

Harbormaster completed remote builds in B76050: Diff 184886.Mon, Aug 24, 2:17 PM
des edited the summary of this revision. (Show Details)Mon, Aug 24, 2:17 PM
des updated this revision to Diff 185092.Tue, Aug 25, 5:41 PM

drop second exists test

Harbormaster completed remote builds in B76160: Diff 185092.Tue, Aug 25, 5:41 PM
markj accepted this revision.Wed, Aug 26, 3:01 PM
This revision is now accepted and ready to land.Wed, Aug 26, 3:01 PM
Closed by commit rGa5ff4125cf08: install: Fix two bugs in stdin code (authored by des). · Explain WhyWed, Aug 26, 5:34 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGa5ff4125cf08: install: Fix two bugs in stdin code.
des added a commit: rG724c344aeded: install: Fix two bugs in stdin code.Thu, Aug 27, 6:35 AM
des added a commit: rG203438d0a38c: install: Fix two bugs in stdin code.
cperciva added a commit: rG5805e0ec8872: install: Fix two bugs in stdin code.Thu, Aug 27, 11:28 PM

Revision Contents
Changeset List

PathSize
usr.bin/
xinstall/
tests/
24 lines
6 lines

Diff 185160

View Options

usr.bin/xinstall/tests/install_test.sh

Loading...
View Options

usr.bin/xinstall/xinstall.c

Loading...