snd_hdsp*: malloc(9) with M_WAITOK
ClosedPublic
Actions

Authored by christos on Fri, Aug 21, 12:47 PM.

Tags

None

Referenced Files

	F170089887: D59079.diff
	Thu, Sep 3, 11:47 AM

	F169976009: D59079.id184736.diff
	Thu, Sep 3, 3:55 AM

	F169936854: D59079.id.diff
	Thu, Sep 3, 12:54 AM

	F169879860: D59079.diff
	Wed, Sep 2, 9:09 PM

	F169874500: D59079.id184645.diff
	Wed, Sep 2, 8:50 PM

	Unknown Object (File)
	Tue, Sep 1, 9:46 PM

	Unknown Object (File)
	Tue, Sep 1, 1:45 AM

	Unknown Object (File)
	Mon, Aug 31, 8:55 PM

View All 44 Files

Subscribers

imp

Details

Reviewers

markj
emaste
kib

Commits

rGb5c1ab6c8f28: snd_hdsp*: malloc(9) with M_WAITOK

Summary

Perform the allocations outside the lock section so that we can use
M_WAITOK. Holding the lock here is actually not really necessary and we
could just as well remove it, but keep it for consistency.

Sponsored by: The FreeBSD Foundation
MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Fri, Aug 21, 12:47 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 21, 12:47 PM

christos requested review of this revision.Fri, Aug 21, 12:47 PM

Harbormaster completed remote builds in B75944: Diff 184645.Fri, Aug 21, 12:47 PM

kib accepted this revision.Sat, Aug 22, 5:46 AM

This revision is now accepted and ready to land.Sat, Aug 22, 5:46 AM

Closed by commit rGb5c1ab6c8f28: snd_hdsp*: malloc(9) with M_WAITOK (authored by christos). · Explain WhySat, Aug 22, 12:49 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGb5c1ab6c8f28: snd_hdsp*: malloc(9) with M_WAITOK.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pci/

hdsp-pcm.c

17 lines

hdspe-pcm.c

17 lines

Diff 184736

View Options

sys/dev/sound/pci/hdsp-pcm.c