snd_hdsp*: malloc(9) with M_WAITOK
ClosedPublic
Actions

Authored by christos on Aug 21 2026, 12:47 PM.

Details

Reviewers

markj
emaste
kib

Commits

rGa4ea046d3843: snd_hdsp*: malloc(9) with M_WAITOK
rGb5c1ab6c8f28: snd_hdsp*: malloc(9) with M_WAITOK

Summary

Perform the allocations outside the lock section so that we can use
M_WAITOK. Holding the lock here is actually not really necessary and we
could just as well remove it, but keep it for consistency.

Sponsored by: The FreeBSD Foundation
MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75944
Build 72827: arc lint + arc unit

Event Timeline

christos created this revision.Aug 21 2026, 12:47 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 21 2026, 12:47 PM

christos requested review of this revision.Aug 21 2026, 12:47 PM

Harbormaster completed remote builds in B75944: Diff 184645.Aug 21 2026, 12:47 PM

kib accepted this revision.Aug 22 2026, 5:46 AM

This revision is now accepted and ready to land.Aug 22 2026, 5:46 AM

Closed by commit rGb5c1ab6c8f28: snd_hdsp*: malloc(9) with M_WAITOK (authored by christos). · Explain WhyAug 22 2026, 12:49 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGb5c1ab6c8f28: snd_hdsp*: malloc(9) with M_WAITOK.

christos added a commit: rGa4ea046d3843: snd_hdsp*: malloc(9) with M_WAITOK.Mon, Sep 21, 11:05 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pci/

hdsp-pcm.c

17 lines

hdspe-pcm.c

17 lines

Diff 184645

View Options

sys/dev/sound/pci/hdsp-pcm.c