Differential D58810

bnxt: Add led(4) identification support
ClosedPublic
Actions

Authored by kbowling on Wed, Aug 12, 8:16 PM.

Tags

None

Referenced Files

	F167481370: D58810.diff
	Sat, Aug 22, 3:15 AM

	F167415716: D58810.id183944.diff
	Fri, Aug 21, 3:19 PM

	F167408874: D58810.id183944.diff
	Fri, Aug 21, 2:42 PM

	Unknown Object (File)
	Thu, Aug 20, 9:38 PM

	Unknown Object (File)
	Thu, Aug 20, 6:55 PM

	Unknown Object (File)
	Thu, Aug 20, 3:56 PM

	Unknown Object (File)
	Thu, Aug 20, 1:09 PM

	Unknown Object (File)
	Thu, Aug 20, 10:39 AM

View All 13 Files

Subscribers

Details

Reviewers

sumit.saxena_broadcom.com
gallatin
shurd

Summary

Query the firmware for the LEDs on each physical port and expose
/dev/led/bnxt* only when alternate blinking is supported.  Configure
every LED in the advertised group for identification and restore its
default firmware state before a function reset.

This is a structural port of DPDK bnxt HWRM identification path,
confirmed against Linux where old hwrm (0x10601) was observed.

Test Plan

I would have to go dig through my tubs-o-NICs at my lab to find suitable HW so this has not been witnessed for sensible LED function.

echo 1 > /dev/led/bnxt0
and sight check is reasonable. Could monitor the registers also.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Wed, Aug 12, 8:16 PM

Herald added a reviewer: shurd. · View Herald TranscriptWed, Aug 12, 8:16 PM

Herald added subscribers: ziaee, imp. · View Herald Transcript

kbowling requested review of this revision.Wed, Aug 12, 8:16 PM

LGTM, but holding back approval as I don't feel like I own this driver..

sumit.saxena_broadcom.com accepted this revision.Thu, Aug 13, 5:56 AM

This revision is now accepted and ready to land.Thu, Aug 13, 5:56 AM

Committed as 98b5640786f874949e441bee7c4ad5740cd6a649

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

7 lines

sys/

dev/

bnxt/

bnxt_en/

15 lines

2 lines

106 lines

41 lines

Diff 183944

share/man/man4/bnxt.4

Loading...

sys/dev/bnxt/bnxt_en/bnxt.h

Loading...

sys/dev/bnxt/bnxt_en/bnxt_hwrm.h

Loading...

sys/dev/bnxt/bnxt_en/bnxt_hwrm.c

Loading...

sys/dev/bnxt/bnxt_en/if_bnxt.c

Loading...