netmap: Handle overflow when computing ring sizes
ClosedPublic
Actions

Authored by markj on Wed, Aug 5, 5:37 PM.

Details

Reviewers

vmaffione

Commits

rG319414a926af: netmap: Handle overflow when computing ring sizes

Summary

PR: 297300
Reported by: Robert Morris
Reported by: syzkaller

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75416
Build 72299: arc lint + arc unit

Event Timeline

markj created this revision.Wed, Aug 5, 5:37 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 5, 5:37 PM

markj requested review of this revision.Wed, Aug 5, 5:37 PM

Harbormaster completed remote builds in B75397: Diff 183475.Wed, Aug 5, 5:37 PM

markj added a parent revision: D58677: netmap: Fix a race in kqueue registration.Wed, Aug 5, 5:37 PM

vmaffione added a subscriber: giuseppe.lettieri_unipi.it.Thu, Aug 6, 7:14 AM

vmaffione requested changes to this revision.Thu, Aug 6, 7:16 AM

vmaffione added inline comments.

sys/dev/netmap/netmap_mem2.c
2024	Aren't we missing `len += sizeof(struct netmap_ring)` ?

This revision now requires changes to proceed.Thu, Aug 6, 7:16 AM

Add missing addition

Harbormaster completed remote builds in B75416: Diff 183537.Thu, Aug 6, 1:10 PM

vmaffione accepted this revision.Fri, Aug 7, 1:35 PM

This revision is now accepted and ready to land.Fri, Aug 7, 1:35 PM

Closed by commit rG319414a926af: netmap: Handle overflow when computing ring sizes (authored by markj). · Explain WhyFri, Aug 7, 4:30 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG319414a926af: netmap: Handle overflow when computing ring sizes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

netmap/

netmap_mem2.c

22 lines

Diff 183537

View Options

sys/dev/netmap/netmap_mem2.c

netmap: Handle overflow when computing ring sizesClosedPublicActions