bhyve: tpm: Avoid printing a message when clearing the cancel bit
ClosedPublic
Actions

Authored by markj on Sep 8 2025, 3:17 PM.

Details

Reviewers

Group Reviewers

Commits

rG582e01321ac6: bhyve: tpm: Avoid printing a message when clearing the cancel bit
rG1c1a3646a1c8: bhyve: tpm: Avoid printing a message when clearing the cancel bit

Summary

Some drivers do this routinely, e.g., FreeBSD's tpm20 does this every
time it sends a command in tpmcrb_transmit(). This causes the console
to fill up with messages. Instead, only print a warning if the cancel
bit is set to one.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Sep 8 2025, 3:17 PM

Herald added a reviewer: bhyve. · View Herald TranscriptSep 8 2025, 3:17 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Sep 8 2025, 3:17 PM

Harbormaster completed remote builds in B66888: Diff 161713.Sep 8 2025, 3:17 PM

corvink accepted this revision.Sep 15 2025, 10:16 AM

This revision is now accepted and ready to land.Sep 15 2025, 10:16 AM

Closed by commit rG1c1a3646a1c8: bhyve: tpm: Avoid printing a message when clearing the cancel bit (authored by markj). · Explain WhyFri, Jul 31, 2:30 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG1c1a3646a1c8: bhyve: tpm: Avoid printing a message when clearing the cancel bit.

markj added a commit: rG582e01321ac6: bhyve: tpm: Avoid printing a message when clearing the cancel bit.Mon, Aug 17, 12:10 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

tpm_intf_crb.c

15 lines

Diff 183158

View Options

usr.sbin/bhyve/tpm_intf_crb.c

bhyve: tpm: Avoid printing a message when clearing the cancel bitClosedPublicActions