ietp: guard iicbus_get_addr with devclass check
ClosedPublic
Actions

Authored by seuros on Jul 24 2026, 11:45 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Sep 12, 9:12 AM

	Unknown Object (File)
	Thu, Sep 10, 7:15 PM

	Unknown Object (File)
	Wed, Sep 9, 8:16 PM

	Unknown Object (File)
	Tue, Sep 8, 11:00 PM

	Unknown Object (File)
	Tue, Sep 8, 1:13 AM

	Unknown Object (File)
	Mon, Sep 7, 9:22 PM

	Unknown Object (File)
	Sun, Sep 6, 1:08 AM

	Unknown Object (File)
	Sun, Sep 6, 12:56 AM

View All 56 Files

Subscribers

imp

Details

Reviewers

adrian
wulf

Commits

rG3fbffbcbec88: ietp: guard iicbus_get_addr with devclass check

Summary

When a USB HID device triggers identify,
the grandparent is usbhid on a USB hub.
Calling iicbus_get_addr() on a non-iicbus device
hits a KASSERT panic.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75085
Build 71968: arc lint + arc unit

Event Timeline

seuros created this revision.Jul 24 2026, 11:45 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 24 2026, 11:45 AM

seuros requested review of this revision.Jul 24 2026, 11:45 AM

Harbormaster completed remote builds in B75085: Diff 182601.Jul 24 2026, 11:45 AM

adrian accepted this revision.Jul 24 2026, 2:28 PM

adrian added projects: USB, drivers.

This revision is now accepted and ready to land.Jul 24 2026, 2:29 PM

adrian added a reviewer: wulf.Jul 24 2026, 2:29 PM

Closed by commit rG3fbffbcbec88: ietp: guard iicbus_get_addr with devclass check (authored by seuros, committed by adrian). · Explain WhyJul 25 2026, 2:02 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG3fbffbcbec88: ietp: guard iicbus_get_addr with devclass check.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hid/

ietp.c

11 lines

Diff 182601

View Options

ietp: guard iicbus_get_addr with devclass checkClosedPublicActions