ietp: guard iicbus_get_addr with devclass check
ClosedPublic
Actions

Authored by seuros on Jul 24 2026, 11:45 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sat, Oct 10, 3:36 PM

	Unknown Object (File)
	Wed, Oct 7, 7:24 AM

	Unknown Object (File)
	Wed, Oct 7, 12:19 AM

	Unknown Object (File)
	Tue, Oct 6, 6:38 AM

	Unknown Object (File)
	Mon, Oct 5, 3:19 PM

	Unknown Object (File)
	Thu, Oct 1, 5:04 PM

	Unknown Object (File)
	Thu, Oct 1, 4:57 AM

	Unknown Object (File)
	Tue, Sep 29, 10:42 PM

View All 71 Files

Subscribers

imp

Details

Reviewers

adrian
wulf

Commits

rG3fbffbcbec88: ietp: guard iicbus_get_addr with devclass check

Summary

When a USB HID device triggers identify,
the grandparent is usbhid on a USB hub.
Calling iicbus_get_addr() on a non-iicbus device
hits a KASSERT panic.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75085
Build 71968: arc lint + arc unit

Event Timeline

seuros created this revision.Jul 24 2026, 11:45 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 24 2026, 11:45 AM

seuros requested review of this revision.Jul 24 2026, 11:45 AM

Harbormaster completed remote builds in B75085: Diff 182601.Jul 24 2026, 11:45 AM

adrian accepted this revision.Jul 24 2026, 2:28 PM

adrian added projects: USB, drivers.

This revision is now accepted and ready to land.Jul 24 2026, 2:29 PM

adrian added a reviewer: wulf.Jul 24 2026, 2:29 PM

Closed by commit rG3fbffbcbec88: ietp: guard iicbus_get_addr with devclass check (authored by seuros, committed by adrian). · Explain WhyJul 25 2026, 2:02 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG3fbffbcbec88: ietp: guard iicbus_get_addr with devclass check.

Revision Contents
Changeset List

Path

Size

sys/

dev/

hid/

ietp.c

11 lines

Diff 182601

View Options

ietp: guard iicbus_get_addr with devclass checkClosedPublicActions