install: Code cleanup
ClosedPublic
Actions

Authored by des on Jul 20 2026, 8:55 AM.

Tags

None

Referenced Files

	F170507134: D58355.id.diff
	Sat, Sep 5, 3:50 AM

	F170475688: D58355.id182279.diff
	Sat, Sep 5, 12:17 AM

	F170475589: D58355.id182279.diff
	Sat, Sep 5, 12:16 AM

	Unknown Object (File)
	Fri, Sep 4, 5:30 AM

	Unknown Object (File)
	Thu, Sep 3, 10:09 PM

	Unknown Object (File)
	Thu, Sep 3, 5:52 PM

	Unknown Object (File)
	Thu, Sep 3, 12:10 PM

	Unknown Object (File)
	Wed, Sep 2, 5:30 AM

View All 48 Files

Subscribers

imp

Details

Reviewers

imp

Commits

rGc8a0269f74b6: install: Code cleanup
rG823e3bbb3080: install: Code cleanup
rG134ddd372f82: install: Code cleanup

Summary

This is mainy focused on using bool for booleans but also renames some
variables for clarity, adds some explicit comparisons, adds some braces,
with miscellanous style fixes thrown in.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74949
Build 71832: arc lint + arc unit

Event Timeline

des created this revision.Jul 20 2026, 8:55 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 20 2026, 8:55 AM

des requested review of this revision.Jul 20 2026, 8:55 AM

Harbormaster completed remote builds in B74949: Diff 182279.Jul 20 2026, 8:56 AM

des added a parent revision: D58348: install: Allow installing stdin.Jul 20 2026, 8:56 AM

seems good, but didn't pedantically check all the options.

This revision is now accepted and ready to land.Jul 20 2026, 10:21 PM

Closed by commit rG134ddd372f82: install: Code cleanup (authored by des). · Explain WhyJul 21 2026, 11:35 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG134ddd372f82: install: Code cleanup.

des added a commit: rG823e3bbb3080: install: Code cleanup.Jul 28 2026, 9:35 AM

des added a commit: rGc8a0269f74b6: install: Code cleanup.

Revision Contents
Changeset List

Path

Size

usr.bin/

xinstall/

xinstall.c

210 lines

Diff 182279

View Options

usr.bin/xinstall/xinstall.c

install: Code cleanupClosedPublicActions