Page MenuHomeFreeBSD
Differential D58113

libfetch: Reduce copying
ClosedPublic
Actions

Authored by des on Jul 8 2026, 5:35 PM.
Tags
None
Referenced Files
F170701830: D58113.id181884.diff
Sun, Sep 6, 2:41 AM
F170698729: D58113.id181552.diff
Sun, Sep 6, 2:18 AM
F170665591: D58113.id181700.diff
Sat, Sep 5, 10:03 PM
F170610822: D58113.id181552.diff
Sat, Sep 5, 3:29 PM
F170597905: D58113.id.diff
Sat, Sep 5, 2:08 PM
F170567275: D58113.id181884.diff
Sat, Sep 5, 10:56 AM
Unknown Object (File)
Fri, Sep 4, 4:28 PM
Unknown Object (File)
Fri, Sep 4, 2:35 PM
View All 59 Files
Subscribers
imp

Details

Reviewers
op
Commits
rG6eaa8ed5d203: libfetch: Reduce copying
rG520105c23a89: libfetch: Reduce copying
rG60382b4a04fa: libfetch: Reduce copying
Summary

Reduce the amount of copying we do when performing buffered reads.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74705
Build 71588: arc lint + arc unit

Event Timeline

des created this revision.Jul 8 2026, 5:35 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 8 2026, 5:35 PM
des requested review of this revision.Jul 8 2026, 5:35 PM
Harbormaster completed remote builds in B74628: Diff 181552.Jul 8 2026, 5:35 PM
op added inline comments.Jul 9 2026, 11:34 PM
lib/libfetch/common.c
1464–1465
lib/libfetch/http.c
152

Is this needed?

des added inline comments.Jul 10 2026, 7:49 AM
lib/libfetch/common.c
1464–1465

I like my version better. But also, you should post this in D57907, where it was added.

lib/libfetch/http.c
152

No, thank you for catching it.

des updated this revision to Diff 181700.Jul 10 2026, 2:01 PM

drop debugf

Harbormaster completed remote builds in B74705: Diff 181700.Jul 10 2026, 2:01 PM
des marked 2 inline comments as done.Jul 10 2026, 2:01 PM
op accepted this revision.Jul 11 2026, 10:25 PM
This revision is now accepted and ready to land.Jul 11 2026, 10:25 PM
Closed by commit rG60382b4a04fa: libfetch: Reduce copying (authored by des). · Explain WhyJul 13 2026, 6:46 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG60382b4a04fa: libfetch: Reduce copying.
des added a commit: rG520105c23a89: libfetch: Reduce copying.Jul 21 2026, 5:05 PM
des added a commit: rG6eaa8ed5d203: libfetch: Reduce copying.

Revision Contents
Changeset List

PathSize
lib/
libfetch/
2 lines
45 lines
23 lines
41 lines

Diff 181700

View Options

lib/libfetch/common.h

Loading...
View Options

lib/libfetch/common.c

Loading...
View Options

lib/libfetch/ftp.c

Loading...
View Options

lib/libfetch/http.c

Loading...