Page MenuHomeFreeBSD
Differential D58113

libfetch: Reduce copying
ClosedPublic
Actions

Authored by des on Wed, Jul 8, 5:35 PM.
Tags
None
Referenced Files
F162426058: D58113.id181700.diff
Mon, Jul 13, 3:42 AM
F162415008: D58113.id181552.diff
Mon, Jul 13, 1:08 AM
Unknown Object (File)
Sun, Jul 12, 1:10 PM
Unknown Object (File)
Sun, Jul 12, 1:40 AM
Subscribers
imp

Details

Reviewers
op
Commits
rG60382b4a04fa: libfetch: Reduce copying
Summary

Reduce the amount of copying we do when performing buffered reads.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74705
Build 71588: arc lint + arc unit

Event Timeline

des created this revision.Wed, Jul 8, 5:35 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Jul 8, 5:35 PM
des requested review of this revision.Wed, Jul 8, 5:35 PM
Harbormaster completed remote builds in B74628: Diff 181552.Wed, Jul 8, 5:35 PM
op added inline comments.Thu, Jul 9, 11:34 PM
lib/libfetch/common.c
1464–1465
lib/libfetch/http.c
152

Is this needed?

des added inline comments.Fri, Jul 10, 7:49 AM
lib/libfetch/common.c
1464–1465

I like my version better. But also, you should post this in D57907, where it was added.

lib/libfetch/http.c
152

No, thank you for catching it.

des updated this revision to Diff 181700.Fri, Jul 10, 2:01 PM

drop debugf

Harbormaster completed remote builds in B74705: Diff 181700.Fri, Jul 10, 2:01 PM
des marked 2 inline comments as done.Fri, Jul 10, 2:01 PM
op accepted this revision.Sat, Jul 11, 10:25 PM
This revision is now accepted and ready to land.Sat, Jul 11, 10:25 PM
Closed by commit rG60382b4a04fa: libfetch: Reduce copying (authored by des). · Explain WhyMon, Jul 13, 6:46 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG60382b4a04fa: libfetch: Reduce copying.

Revision Contents
Changeset List

PathSize
lib/
libfetch/
2 lines
45 lines
23 lines
41 lines

Diff 181700

View Options

lib/libfetch/common.h

Loading...
View Options

lib/libfetch/common.c

Loading...
View Options

lib/libfetch/ftp.c

Loading...
View Options

lib/libfetch/http.c

Loading...