Page MenuHomeFreeBSD
Differential D58150

libnetmap: fix error path in nmport_extmem_from_file
ClosedPublic
Actions

Authored by jlduran on Fri, Jul 10, 10:50 AM.
Tags
None
Referenced Files
F162678662: D58150.diff
Wed, Jul 15, 4:20 PM
F162678486: D58150.diff
Wed, Jul 15, 4:16 PM
F162591597: D58150.diff
Tue, Jul 14, 8:54 PM
Unknown Object (File)
Mon, Jul 13, 10:52 PM
Unknown Object (File)
Sun, Jul 12, 10:37 PM
Unknown Object (File)
Sun, Jul 12, 2:36 PM
Subscribers
imp

Details

Reviewers
vmaffione
zlei
Group Reviewers
network
Commits
rGfcaf15e54162: libnetmap: fix error path in nmport_extmem_from_file
Summary

Obtained from: https://github.com/luigirizzo/netmap/commit/b52a2bcae35e56548acfb0849b248a1e4b0c0c3b

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74696
Build 71579: arc lint + arc unit

Event Timeline

jlduran created this revision.Fri, Jul 10, 10:50 AM
Herald added a subscriber: imp. · View Herald TranscriptFri, Jul 10, 10:50 AM
jlduran requested review of this revision.Fri, Jul 10, 10:50 AM
Harbormaster completed remote builds in B74696: Diff 181689.Fri, Jul 10, 10:50 AM
jlduran added a child revision: D58151: libnetmap: fix extra indirection in nmreq_remove_option.Fri, Jul 10, 10:50 AM
jlduran added a reviewer: network.Fri, Jul 10, 10:51 AM
zlei accepted this revision as: zlei.Mon, Jul 13, 7:25 AM
zlei added a reviewer: vmaffione.
This revision is now accepted and ready to land.Mon, Jul 13, 7:26 AM
vmaffione accepted this revision.Mon, Jul 13, 7:57 AM

Do you need me to commit this?

Closed by commit rGfcaf15e54162: libnetmap: fix error path in nmport_extmem_from_file (authored by jlduran). · Explain WhyMon, Jul 13, 12:27 PM
This revision was automatically updated to reflect the committed changes.
jlduran added a commit: rGfcaf15e54162: libnetmap: fix error path in nmport_extmem_from_file.
jlduran added a comment.Mon, Jul 13, 12:29 PM
In D58150#1334946, @vmaffione wrote:

Do you need me to commit this?

No need thank you! I'm trying to reduce the differences, to then sync. I started with the non-functional changes here:
https://github.com/luigirizzo/netmap/pull/989

Revision Contents
Changeset List

PathSize
lib/
libnetmap/
4 lines

Diff 181689

View Options

lib/libnetmap/nmport.c

Loading...