Page MenuHomeFreeBSD
Differential D58113

libfetch: Reduce copying
ClosedPublic
Actions

Authored by des on Wed, Jul 8, 5:35 PM.
Tags
None
Referenced Files
F163604083: D58113.id181884.diff
Fri, Jul 24, 8:46 PM
Unknown Object (File)
Thu, Jul 23, 6:23 PM
Unknown Object (File)
Wed, Jul 22, 12:21 PM
Unknown Object (File)
Wed, Jul 22, 12:21 PM
Unknown Object (File)
Fri, Jul 17, 5:46 PM
Unknown Object (File)
Thu, Jul 16, 3:50 AM
Unknown Object (File)
Wed, Jul 15, 9:41 PM
Unknown Object (File)
Wed, Jul 15, 5:57 PM
View All 17 Files
Subscribers
imp

Details

Reviewers
op
Commits
rG6eaa8ed5d203: libfetch: Reduce copying
rG520105c23a89: libfetch: Reduce copying
rG60382b4a04fa: libfetch: Reduce copying
Summary

Reduce the amount of copying we do when performing buffered reads.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74628
Build 71511: arc lint + arc unit

Event Timeline

des created this revision.Wed, Jul 8, 5:35 PM
Herald added a subscriber: imp. · View Herald TranscriptWed, Jul 8, 5:35 PM
des requested review of this revision.Wed, Jul 8, 5:35 PM
Harbormaster completed remote builds in B74628: Diff 181552.Wed, Jul 8, 5:35 PM
op added inline comments.Thu, Jul 9, 11:34 PM
lib/libfetch/common.c
1464
lib/libfetch/http.c
152

Is this needed?

des added inline comments.Fri, Jul 10, 7:49 AM
lib/libfetch/common.c
1464

I like my version better. But also, you should post this in D57907, where it was added.

lib/libfetch/http.c
152

No, thank you for catching it.

des updated this revision to Diff 181700.Fri, Jul 10, 2:01 PM

drop debugf

Harbormaster completed remote builds in B74705: Diff 181700.Fri, Jul 10, 2:01 PM
des marked 2 inline comments as done.Fri, Jul 10, 2:01 PM
op accepted this revision.Sat, Jul 11, 10:25 PM
This revision is now accepted and ready to land.Sat, Jul 11, 10:25 PM
Closed by commit rG60382b4a04fa: libfetch: Reduce copying (authored by des). · Explain WhyMon, Jul 13, 6:46 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG60382b4a04fa: libfetch: Reduce copying.
des added a commit: rG520105c23a89: libfetch: Reduce copying.Tue, Jul 21, 5:05 PM
des added a commit: rG6eaa8ed5d203: libfetch: Reduce copying.

Revision Contents
Changeset List

PathSize
lib/
libfetch/
2 lines
45 lines
23 lines
42 lines

Diff 181552

View Options

lib/libfetch/common.h

Loading...
View Options

lib/libfetch/common.c

Loading...
View Options

lib/libfetch/ftp.c

Loading...
View Options

lib/libfetch/http.c

Loading...