Page MenuHomeFreeBSD
Differential D58091

fwcam: set ISO speed from device link speed
ClosedPublic
Actions

Authored by guest-seuros on Tue, Jul 7, 5:54 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Jul 15, 7:29 AM
Unknown Object (File)
Wed, Jul 15, 7:29 AM
Unknown Object (File)
Wed, Jul 15, 6:57 AM
Unknown Object (File)
Wed, Jul 15, 5:43 AM
Unknown Object (File)
Tue, Jul 14, 8:46 PM
Unknown Object (File)
Tue, Jul 14, 8:05 PM
Unknown Object (File)
Tue, Jul 14, 6:20 PM
Unknown Object (File)
Tue, Jul 14, 12:24 PM
View All 18 Files
Subscribers
imp

Details

Reviewers
adrian
Group Reviewers
firewire
Commits
rG4e0fc4d44dc1: fwcam: set ISO speed from device link speed
Summary

iso_speed was never initialized, defaulting to S100 regardless of the
camera's actual link speed. Some cameras firmwares reject ISO_EN
when the speed field in the ISO_CHANNEL register
does not match their capabilities.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74596
Build 71479: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Tue, Jul 7, 5:54 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jul 7, 5:54 PM
guest-seuros requested review of this revision.Tue, Jul 7, 5:54 PM
Harbormaster completed remote builds in B74596: Diff 181470.Tue, Jul 7, 5:54 PM
guest-seuros added a reviewer: firewire.Tue, Jul 7, 5:54 PM
guest-seuros added projects: firewire, drivers.
guest-seuros added a comment.Tue, Jul 7, 5:58 PM

S400 is the default in non apple hardware.

Apple firmware handle the negotiation automatically from what it seems.

This fix is for non-apple cards.

guest-seuros added a parent revision: D58090: fwcam: add dynamic resolution and frame rate support.Tue, Jul 7, 8:11 PM
guest-seuros added a child revision: D58092: fwcam: write video mode registers before enabling ISO streaming.
adrian accepted this revision.Tue, Jul 7, 8:44 PM

accepted; tested!

This revision is now accepted and ready to land.Tue, Jul 7, 8:44 PM
Closed by commit rG4e0fc4d44dc1: fwcam: set ISO speed from device link speed (authored by guest-seuros, committed by adrian). · Explain WhyWed, Jul 8, 5:42 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG4e0fc4d44dc1: fwcam: set ISO speed from device link speed.

Revision Contents
Changeset List

PathSize
sys/
dev/
firewire/
1 line

Diff 181470

View Options

sys/dev/firewire/fwcam.c

Loading...