Differential D58033

fwohci: fix LPS delay, PHY_INT storm, and SID timeout recovery
ClosedPublic
Actions

Authored by guest-seuros on Jul 3 2026, 8:49 PM.

Tags

Referenced Files

	Unknown Object (File)
	Sun, Aug 9, 7:58 PM

	Unknown Object (File)
	Sun, Aug 9, 2:39 PM

	Unknown Object (File)
	Sun, Aug 9, 1:22 PM

	Unknown Object (File)
	Sat, Aug 8, 11:05 PM

	Unknown Object (File)
	Sat, Aug 8, 11:25 AM

	Unknown Object (File)
	Sat, Aug 8, 11:21 AM

	Unknown Object (File)
	Sat, Aug 8, 9:25 AM

	Unknown Object (File)
	Sat, Aug 8, 7:18 AM

View All 33 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG4b3d03566821: fwohci: fix LPS delay, PHY_INT storm, and SID timeout recovery

Summary

Fixed the post-LPS delay from 500us to the IEEE 1394a-2000 s6.1 mandated
10ms ceiling. Handled PHY_INT by clearing W1C status bits in register 5
(masked ISBR to avoid spurious bus resets). Added a SID timeout callout
that recovers the state machine when a remote device fails to complete
self-ID. Fixed FW_PHY_SPD operator precedence and gated noisy messages
behind bootverbose/firewire_debug.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

guest-seuros created this revision.Jul 3 2026, 8:49 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 3 2026, 8:49 PM

guest-seuros requested review of this revision.Jul 3 2026, 8:49 PM

Harbormaster completed remote builds in B74516: Diff 181276.Jul 3 2026, 8:49 PM

guest-seuros added projects: drivers, firewire.Jul 3 2026, 8:51 PM

Note: Linux has 50ms delay. The spec has 10ms.

The hardware i tested did not need more than 10ms.

guest-seuros added a reviewer: firewire.Jul 7 2026, 4:20 PM

guest-seuros added a child revision: D57914: fwcamctl: add control utility for fwcam(4) IIDC FireWire cameras.Jul 7 2026, 8:10 PM

guest-seuros added a child revision: D58090: fwcam: add dynamic resolution and frame rate support.

approved; tested locally

This revision is now accepted and ready to land.Jul 7 2026, 8:42 PM

Closed by commit rG4b3d03566821: fwohci: fix LPS delay, PHY_INT storm, and SID timeout recovery (authored by guest-seuros, committed by adrian). · Explain WhyJul 8 2026, 5:42 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG4b3d03566821: fwohci: fix LPS delay, PHY_INT storm, and SID timeout recovery.

Revision Contents
Changeset List

Path

Size

sys/

dev/

firewire/

59 lines

3 lines

Diff 181511

sys/dev/firewire/fwohci.c

Loading...

sys/dev/firewire/fwohcivar.h

Loading...