Page MenuHomeFreeBSD
Differential D58092

fwcam: write video mode registers before enabling ISO streaming
ClosedPublic
Actions

Authored by guest-seuros on Tue, Jul 7, 7:11 PM.
Tags
Referenced Files
F162325140: D58092.id181490.diff
Sun, Jul 12, 1:58 AM
F162323129: D58092.id181514.diff
Sun, Jul 12, 1:32 AM
F162288409: D58092.diff
Sat, Jul 11, 5:49 PM
F162287637: D58092.diff
Sat, Jul 11, 5:38 PM
F162287150: D58092.id181474.diff
Sat, Jul 11, 5:32 PM
Unknown Object (File)
Fri, Jul 10, 5:44 PM
Unknown Object (File)
Wed, Jul 8, 4:26 PM
Unknown Object (File)
Wed, Jul 8, 4:53 AM
View All 9 Files
Subscribers
imp

Details

Reviewers
adrian
Group Reviewers
firewire
Commits
rG84044a77a620: fwcam: write video mode registers before enabling ISO streaming
Summary

The IIDC spec (s3.1) requires the video mode to be programmed before ISO
enable. Without this, cameras that power up with invalid default
mode/rate combinations reject the ISO_EN write.

This can happen when the firmware of teh camera is outdated or
vendor never updated it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

guest-seuros created this revision.Tue, Jul 7, 7:11 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Jul 7, 7:11 PM
guest-seuros requested review of this revision.Tue, Jul 7, 7:11 PM
Harbormaster completed remote builds in B74599: Diff 181474.Tue, Jul 7, 7:12 PM
guest-seuros added a reviewer: firewire.Tue, Jul 7, 7:12 PM
guest-seuros added projects: firewire, drivers.
guest-seuros added a parent revision: D58091: fwcam: set ISO speed from device link speed.Tue, Jul 7, 8:11 PM
adrian added inline comments.Tue, Jul 7, 8:41 PM
sys/dev/firewire/fwcam.c
411

add _SHIFT defines for this, like other register definitions have!

434

Add a definition for this particular bit like other registers

adrian added a child revision: D57914: fwcamctl: add control utility for fwcam(4) IIDC FireWire cameras.Tue, Jul 7, 8:41 PM
guest-seuros updated this revision to Diff 181490.Tue, Jul 7, 10:02 PM

use constant. address review.

Harbormaster completed remote builds in B74604: Diff 181490.Tue, Jul 7, 10:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jul 8, 5:42 AM
Closed by commit rG84044a77a620: fwcam: write video mode registers before enabling ISO streaming (authored by guest-seuros, committed by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG84044a77a620: fwcam: write video mode registers before enabling ISO streaming.

Revision Contents
Changeset List

PathSize
sys/
dev/
firewire/
7 lines
40 lines

Diff 181514

View Options

sys/dev/firewire/fwcam.h

Loading...
View Options

sys/dev/firewire/fwcam.c

Loading...