Differential D58090

fwcam: add dynamic resolution and frame rate support
ClosedPublic
Actions

Authored by guest-seuros on Tue, Jul 7, 5:38 PM.

Details

Reviewers

adrian

Group Reviewers

firewire

Commits

rGf4825e91cf77: fwcam: add dynamic resolution and frame rate support

Summary

Read V_MODE_INQ and V_RATE_INQ registers for all supported formats
during probe, caching the camera's actual capabilities. Use these
to validate SMODE ioctl requests before writing to the camera.

Writing an unsupported combination caused the camera to
stop responding, requiring a physical power cycle.

Tested with: Apple iSight (external FireWire)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74593
Build 71476: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Tue, Jul 7, 5:38 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Jul 7, 5:38 PM

guest-seuros requested review of this revision.Tue, Jul 7, 5:38 PM

Harbormaster completed remote builds in B74593: Diff 181467.Tue, Jul 7, 5:38 PM

guest-seuros added a reviewer: firewire.Tue, Jul 7, 5:39 PM

guest-seuros added projects: drivers, firewire.

guest-seuros added a parent revision: D58033: fwohci: fix LPS delay, PHY_INT storm, and SID timeout recovery.Tue, Jul 7, 8:10 PM

guest-seuros added a child revision: D58091: fwcam: set ISO speed from device link speed.

tested; my camera only announces VGA resolution though!

This revision is now accepted and ready to land.Tue, Jul 7, 8:44 PM

Closed by commit rGf4825e91cf77: fwcam: add dynamic resolution and frame rate support (authored by guest-seuros, committed by adrian). · Explain WhyWed, Jul 8, 5:42 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGf4825e91cf77: fwcam: add dynamic resolution and frame rate support.

Revision Contents
Changeset List

Path

Size

sys/

dev/

firewire/

fwcam.h

2 lines

fwcam.c

33 lines

Diff 181467

View Options

sys/dev/firewire/fwcam.h