loader.efi: Simplify the code for null decompression a little
ClosedPublic
Actions

Authored by imp on Tue, Jul 7, 4:15 AM.

Details

Reviewers

Commits

rG1d1298269d4c: loader.efi: Simplify the code for null decompression a little

Summary

This code is simpler when we spell it the Unix way. Also, add sanity
checks to make sure the offset is where we think it is.

Fixes: afee781523e4 ("loader.efi: Recognize new memdisk=<url> and memcd=<url> options")
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74573
Build 71456: arc lint + arc unit

Event Timeline

imp created this revision.Tue, Jul 7, 4:15 AM

Herald added a reviewer: manu. · View Herald TranscriptTue, Jul 7, 4:15 AM

Herald added subscribers: dab, bcran. · View Herald Transcript

imp requested review of this revision.Tue, Jul 7, 4:15 AM

imp added a parent revision: D58069: loader.efi: Fix off by one error in size of the virtual disk.

Harbormaster completed remote builds in B74573: Diff 181416.Tue, Jul 7, 4:15 AM

imp added a child revision: D58071: Revert "loader.efi: Trim ZFS searching for other booting options".Tue, Jul 7, 4:15 AM

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jul 10, 4:19 AM

Closed by commit rG1d1298269d4c: loader.efi: Simplify the code for null decompression a little (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG1d1298269d4c: loader.efi: Simplify the code for null decompression a little.

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

decompress.c

10 lines

Diff 181416

View Options

stand/efi/loader/decompress.c

loader.efi: Simplify the code for null decompression a littleClosedPublicActions