Differential D58069

loader.efi: Fix off by one error in size of the virtual disk
ClosedPublic
Actions

Authored by imp on Tue, Jul 7, 4:13 AM.

Tags

None

Referenced Files

	F162209491: D58069.diff
	Fri, Jul 10, 10:30 PM

	F162204050: D58069.id181415.diff
	Fri, Jul 10, 9:10 PM

	Unknown Object (File)
	Thu, Jul 9, 8:41 PM

	Unknown Object (File)
	Thu, Jul 9, 12:44 AM

Subscribers

Details

Reviewers

Commits

rG603270b4d69e: loader.efi: Fix off by one error in size of the virtual disk

Summary

The end address is the final byte in the array, not one byte past the
end of the array, so we need to add 1 to get the full length.

Fixes: 59219fc76a4b ("loader.efi: efiblk_memdisk_preload passes the VirtualDisks to FreeBSD")
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Tue, Jul 7, 4:13 AM

Herald added a reviewer: manu. · View Herald TranscriptTue, Jul 7, 4:13 AM

Herald added subscribers: dab, bcran. · View Herald Transcript

imp requested review of this revision.Tue, Jul 7, 4:13 AM

Harbormaster completed remote builds in B74572: Diff 181415.Tue, Jul 7, 4:13 AM

imp added a parent revision: D58068: laoder.efi: Fix error in download protcol.Tue, Jul 7, 4:13 AM

imp added a child revision: D58070: loader.efi: Simplify the code for null decompression a little.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jul 10, 4:19 AM

Closed by commit rG603270b4d69e: loader.efi: Fix off by one error in size of the virtual disk (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG603270b4d69e: loader.efi: Fix off by one error in size of the virtual disk.

Revision Contents
Changeset List

Path

Size

stand/

efi/

libefi/

2 lines

Diff 181659

stand/efi/libefi/efipart.c

Loading...