While here, clean up and simplify the existing code.
MFC after: 1 week
Details
Details
- Reviewers
glebius jhb - Group Reviewers
srcmgr - Commits
- rGff22dcccc089: libsysdecode: Teach mktables to handle enums
rG8b197806dcdf: libsysdecode: Teach mktables to handle enums
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 74461 Build 71344: arc lint + arc unit
Event Timeline
Comment Actions
hmm, given awk's limited regex syntax I think it would be better to process the exclusion using sed and use awk only to pick out enums.
| lib/libsysdecode/mktables | ||
|---|---|---|
| 57 | Having filter be local so it doesn't get created in the global namespace is still nice. | |
| 85 | s/TABLE_NAME/TABLE_START/? (Old bug I think) | |
| 102 | I think the only thing here is that this doesn't permit named enums, only enum {\n... }. That's fine for now I guess, but at some point the regex might have to be relaxed to allow a valid C identifier between enum and the {. | |
| lib/libsysdecode/mktables | ||
|---|---|---|
| 102 | yes it does, the ([[:space:]].*)? bit takes care of that, and I added support for a leading typedef after you commented. I don't want to make it more specific than that because technically there could be attributes (e.g. enum_extensibility) between the enum keyword and the identifier. | |
| lib/libsysdecode/mktables | ||
|---|---|---|
| 102 | I had misread the regex as only matching whitespace. It is pretty generic as you note, but I agree that it's probably not tenable to be more specific than just requiring at least one space before any other non-space characters. | |
Comment Actions
I've merged this to stable/15 but not stable/14 since it does not have the changes to <sys/socket.h> or <sys/netpfil/pf/pf_nl.h> which necessitated the change.