FFL: (cleanup) Change cast when comparing tlen to tp->th_urp
ClosedPublic
Actions

Authored by jtl on Jul 2 2016, 8:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 12, 11:34 PM

	Unknown Object (File)
	Mon, Aug 10, 11:10 AM

	Unknown Object (File)
	Sat, Aug 8, 11:02 PM

	Unknown Object (File)
	Sat, Aug 8, 4:21 PM

	Unknown Object (File)
	Sat, Aug 8, 11:19 AM

	Unknown Object (File)
	Fri, Aug 7, 8:06 PM

	Unknown Object (File)
	Mon, Jul 20, 3:17 AM

	Unknown Object (File)
	Jun 4 2026, 4:37 AM

View All 85 Files

Subscribers

imp

Details

Reviewers

gnn

Group Reviewers

transport

Summary

Cast tlen to uint32_t (instead of u_long) when comparing it to the u_short tp->th_urp. This should be a no-op change, but there is no need to over-promote.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4414
Build 4464: arc lint + arc unit

Event Timeline

jtl updated this revision to Diff 18094.Jul 2 2016, 8:28 PM

jtl retitled this revision from to FFL: (cleanup) Change cast when comparing tlen to tp->th_urp.

jtl updated this object.

jtl edited the test plan for this revision. (Show Details)

jtl added a reviewer: transport.

Herald edited edge metadata. · View Herald TranscriptJul 2 2016, 8:28 PM

Herald added a subscriber: imp. · View Herald Transcript

gnn accepted this revision.Jul 4 2016, 12:27 AM

gnn added a reviewer: gnn.

This revision is now accepted and ready to land.Jul 4 2016, 12:27 AM

Committed in rS306769.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_input.c

2 lines

tcp_stacks/

fastpath.c

2 lines

Diff 18094

View Options

sys/netinet/tcp_input.c