Differential D57895

libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode
ClosedPublic
Actions

Authored by lwhsu on Jun 26 2026, 9:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 16, 7:09 AM

	Unknown Object (File)
	Sat, Aug 15, 9:27 AM

	Unknown Object (File)
	Wed, Aug 12, 11:49 PM

	Unknown Object (File)
	Mon, Aug 10, 11:20 AM

	Unknown Object (File)
	Sun, Aug 9, 7:37 AM

	Unknown Object (File)
	Sun, Aug 9, 5:53 AM

	Unknown Object (File)
	Sun, Aug 9, 4:45 AM

	Unknown Object (File)
	Sat, Aug 8, 7:57 PM

Subscribers

Details

Reviewers

markj
domagoj.stolfa_gmail.com
gnn

Group Reviewers

Commits

rGffdac5099420: libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode
rGe6b49d71f259: libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode
rG8e61d8707f8a: libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode

Summary

libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode

dt_print_sym() fills the symbol string via snprintf() in non-oformat
mode but the guarding `dtp->dt_oformat != 0 &&` for the dt_printf()
causes the symbol is computed but never emitted.

Fixes:		93f27766a7e1 ("dtrace: Add the 'oformat' libdtrace option")
Event:		Halifax Hackathon 202606
Location:	Room 208, Computer Science Building, Dalhousie University
MFC after:	3 days
Sponsored by:	The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 74314
Build 71197: arc lint + arc unit

Event Timeline

lwhsu created this revision.Jun 26 2026, 9:32 PM

Herald added a reviewer: gnn. · View Herald TranscriptJun 26 2026, 9:32 PM

Herald added a subscriber: imp. · View Herald Transcript

lwhsu requested review of this revision.Jun 26 2026, 9:32 PM

Harbormaster completed remote builds in B74314: Diff 180790.Jun 26 2026, 9:32 PM

markj accepted this revision as: markj.Jun 26 2026, 9:39 PM

This revision is now accepted and ready to land.Jun 26 2026, 9:39 PM

Closed by commit rG8e61d8707f8a: libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode (authored by lwhsu). · Explain WhyJun 27 2026, 2:26 AM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rG8e61d8707f8a: libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode.

lwhsu added a commit: rGe6b49d71f259: libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode.Thu, Aug 6, 1:42 AM

lwhsu added a commit: rGffdac5099420: libdtrace: Fix dt_print_sym() not printing symbols in non-oformat mode.

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

lib/

libdtrace/

common/

2 lines

Diff 180790

cddl/contrib/opensolaris/lib/libdtrace/common/dt_consume.c

Loading...