Page MenuHomeFreeBSD
Differential D57893

loader.efi: Fix build with gcc due to pointer / int issues on 32-bit build
ClosedPublic
Actions

Authored by imp on Fri, Jun 26, 7:58 PM.
Tags
None
Referenced Files
F160960254: D57893.diff
Mon, Jun 29, 10:46 AM
Unknown Object (File)
Sun, Jun 28, 1:06 PM
Unknown Object (File)
Sun, Jun 28, 9:56 AM
Subscribers
bcran
dab
rlibby

Details

Reviewers
manu
rlibby
Commits
rG9cb1459633a1: loader.efi: Fix build with gcc due to pointer / int issues on 32-bit build
Summary

Use (uintptr_t) casts to cast the EFI_PHYSICAL_ADDDRESS to a pointer.

Fixes: afee781523e4 ("loader.efi: Recognize new memdisk=<url> and memcd=<url> options")
Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74311
Build 71194: arc lint + arc unit

Event Timeline

imp created this revision.Fri, Jun 26, 7:58 PM
Herald added a reviewer: manu. · View Herald TranscriptFri, Jun 26, 7:58 PM
Herald added subscribers: dab, bcran. · View Herald Transcript
imp requested review of this revision.Fri, Jun 26, 7:58 PM
Harbormaster completed remote builds in B74311: Diff 180785.Fri, Jun 26, 7:58 PM
rlibby accepted this revision.Fri, Jun 26, 8:20 PM
rlibby added a subscriber: rlibby.

Logic LGTM.

I guess we don't follow 80 column limit in this file?

For my education: do we know in the 32-bit environment that physical addresses assuredly are below 4 GB?

This revision is now accepted and ready to land.Fri, Jun 26, 8:20 PM
imp added a comment.Fri, Jun 26, 10:33 PM

Yea. I don't care about 80 columns for the boot loader. It's obsolete and makes the code ugly. I usually wrap around 100 chars..

imp added a comment.Fri, Jun 26, 10:48 PM
In D57893#1327224, @rlibby wrote:

For my education: do we know in the 32-bit environment that physical addresses assuredly are below 4 GB?

Yes. There's only 32-bits, it necessarily has to be below 4GB and has other limits.

Closed by commit rG9cb1459633a1: loader.efi: Fix build with gcc due to pointer / int issues on 32-bit build (authored by imp). · Explain WhyFri, Jun 26, 11:15 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG9cb1459633a1: loader.efi: Fix build with gcc due to pointer / int issues on 32-bit build.

Revision Contents
Changeset List

PathSize
stand/
efi/
loader/
16 lines

Diff 180785

View Options

stand/efi/loader/decompress.c

Loading...