iichid(4): Always release interrupt resource
ClosedPublic
Actions

Authored by obiwac on Fri, Jun 26, 2:29 PM.

Tags

None

Referenced Files

	F162638687: D57886.diff
	Wed, Jul 15, 7:28 AM

	F162638686: D57886.diff
	Wed, Jul 15, 7:28 AM

	F162582816: D57886.diff
	Tue, Jul 14, 6:50 PM

	Unknown Object (File)
	Fri, Jul 10, 12:15 AM

	Unknown Object (File)
	Thu, Jul 9, 10:41 PM

	Unknown Object (File)
	Thu, Jul 9, 12:36 AM

	Unknown Object (File)
	Wed, Jul 8, 6:25 AM

	Unknown Object (File)
	Tue, Jul 7, 11:21 PM

View All 22 Files

Subscribers

imp

Details

Reviewers

wulf
aokblast

Commits

rG0cedb626959c: iichid(4): Always release interrupt resource

Summary

We shouldn't just be doing this when IICHID_SAMPLING is not defined. Also I think it's still worth logging that the interrupt setup failed.

Event: Halifax Hackathon 202606
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74303
Build 71186: arc lint + arc unit

Event Timeline

obiwac created this revision.Fri, Jun 26, 2:29 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jun 26, 2:29 PM

obiwac requested review of this revision.Fri, Jun 26, 2:29 PM

Harbormaster completed remote builds in B74303: Diff 180716.Fri, Jun 26, 2:29 PM

obiwac edited the summary of this revision. (Show Details)Fri, Jun 26, 2:29 PM

LGTM! irq_res = bus_alloc_resource_any is not guarded with IICHID_SAMPLING. It should be paired.

This revision is now accepted and ready to land.Fri, Jun 26, 6:49 PM

Closed by commit rG0cedb626959c: iichid(4): Always release interrupt resource (authored by obiwac). · Explain WhyFri, Jun 26, 7:00 PM

This revision was automatically updated to reflect the committed changes.

obiwac added a commit: rG0cedb626959c: iichid(4): Always release interrupt resource.

Revision Contents
Changeset List

Path

Size

sys/

dev/

iicbus/

iichid.c

8 lines

Diff 180716

View Options

iichid(4): Always release interrupt resourceClosedPublicActions