Page MenuHomeFreeBSD
Differential D57840

local-unbound-setup: Support IPv6-only systems
ClosedPublic
Actions

Authored by des on Thu, Jun 25, 3:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 25, 4:19 PM
Unknown Object (File)
Thu, Jun 25, 2:03 PM
Unknown Object (File)
Thu, Jun 25, 5:50 AM
Unknown Object (File)
Thu, Jun 25, 3:20 AM
Subscribers
imp
jlduran

Details

Reviewers
cy
jlduran
Commits
rGf0a861efbafe: local-unbound-setup: Support IPv6-only systems
Summary
  • In the server configuration, disable protocols not supported by the kernel.
  • In resolv.conf, instead of only using 127.0.0.1, use either 127.0.0.1, ::1, or both depending on which protocols the kernel supports.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74228
Build 71111: arc lint + arc unit

Event Timeline

des created this revision.Thu, Jun 25, 3:06 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, Jun 25, 3:06 AM
des requested review of this revision.Thu, Jun 25, 3:06 AM
Harbormaster completed remote builds in B74227: Diff 180593.Thu, Jun 25, 3:06 AM
des updated this revision to Diff 180594.Thu, Jun 25, 3:07 AM

simplify

Harbormaster completed remote builds in B74228: Diff 180594.Thu, Jun 25, 3:07 AM
jlduran added a subscriber: jlduran.Thu, Jun 25, 4:20 AM

Nice! Thank you!
I think we can simplify and improve the while read ... block, but that is not related to this change.

usr.sbin/unbound/setup/local-unbound-setup.sh
83

In the event someone (like me) tries to reuse this function somewhere else and sysctl returns "".

165

What happens to nameserver localhost (and localhost.*)?
I cannot think of a clean way to handle those without parsing /etc/hosts (which gets ugly), except for leaving nameserver localhost (or localhost.*) unchanged (can we assume that /etc/hosts and /etc/nsswitch.conf are well-configured?).

184

Quick question, if a user has: options timeout:2 attempts:5 edns0, according to the man page this should be accepted. More importantly, shouldn't we keep the other values as well?

des added inline comments.Thu, Jun 25, 8:20 AM
usr.sbin/unbound/setup/local-unbound-setup.sh
83

That's not necessary, any unset or empty variable will evaluate to 0 in an arithmetic expression.

165

I no longer consider them valid. I considered removing them altogether but decided to just comment them out instead.

184

We do.

des updated this revision to Diff 180598.Thu, Jun 25, 9:01 AM

fix edns0 logic

Harbormaster completed remote builds in B74229: Diff 180598.Thu, Jun 25, 9:01 AM
des updated this revision to Diff 180599.Thu, Jun 25, 9:02 AM

consistent style

Harbormaster completed remote builds in B74230: Diff 180599.Thu, Jun 25, 9:02 AM
jlduran accepted this revision.Thu, Jun 25, 9:38 AM
jlduran added inline comments.
usr.sbin/unbound/setup/local-unbound-setup.sh
2

?

This revision is now accepted and ready to land.Thu, Jun 25, 9:38 AM
des added inline comments.Thu, Jun 25, 10:27 AM
usr.sbin/unbound/setup/local-unbound-setup.sh
2

Apparently my Ctrl key is starting to fail...

des updated this revision to Diff 180609.Thu, Jun 25, 10:28 AM

rv

This revision now requires review to proceed.Thu, Jun 25, 10:28 AM
Harbormaster completed remote builds in B74237: Diff 180609.Thu, Jun 25, 10:28 AM
jlduran accepted this revision.Thu, Jun 25, 5:06 PM
This revision is now accepted and ready to land.Thu, Jun 25, 5:06 PM
Closed by commit rGf0a861efbafe: local-unbound-setup: Support IPv6-only systems (authored by des). · Explain WhyFri, Jun 26, 2:43 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGf0a861efbafe: local-unbound-setup: Support IPv6-only systems.

Revision Contents
Changeset List

PathSize
usr.sbin/
unbound/
setup/
50 lines

Diff 180594

View Options

usr.sbin/unbound/setup/local-unbound-setup.sh

Loading...