Paths

Table of Contentst

Differential D57840

local-unbound-setup: Support IPv6-only systems
ClosedPublic
Actions

Authored by des on Jun 25 2026, 3:06 AM.

Tags

None

Referenced Files

	F163982981: D57840.id180593.diff
	Mon, Jul 27, 3:56 PM

	F163972589: D57840.id180609.diff
	Mon, Jul 27, 2:25 PM

	Unknown Object (File)
	Sat, Jul 25, 12:37 PM

	Unknown Object (File)
	Fri, Jul 24, 11:15 PM

	Unknown Object (File)
	Fri, Jul 24, 6:32 PM

	Unknown Object (File)
	Thu, Jul 23, 8:48 PM

	Unknown Object (File)
	Thu, Jul 23, 10:48 AM

	Unknown Object (File)
	Thu, Jul 23, 10:30 AM

View All 49 Files

Subscribers

Details

Reviewers

cy
jlduran

Commits

rGba4033104a89: local-unbound-setup: Support IPv6-only systems
rG973d1f2b12ab: local-unbound-setup: Support IPv6-only systems
rGf0a861efbafe: local-unbound-setup: Support IPv6-only systems

Summary

In the server configuration, disable protocols not supported by the kernel.

In resolv.conf, instead of only using 127.0.0.1, use either 127.0.0.1, ::1, or both depending on which protocols the kernel supports.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74227
Build 71110: arc lint + arc unit

Event Timeline

des created this revision.Jun 25 2026, 3:06 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 25 2026, 3:06 AM

des requested review of this revision.Jun 25 2026, 3:06 AM

Harbormaster completed remote builds in B74227: Diff 180593.Jun 25 2026, 3:06 AM

simplify

Harbormaster completed remote builds in B74228: Diff 180594.Jun 25 2026, 3:07 AM

Nice! Thank you!
I think we can simplify and improve the while read ... block, but that is not related to this change.

usr.sbin/unbound/setup/local-unbound-setup.sh
83	In the event someone (like me) tries to reuse this function somewhere else and `sysctl` returns "".
165–175	What happens to `nameserver localhost` (and `localhost.`)? I cannot think of a clean way to handle those without parsing /etc/hosts (which gets ugly), except for leaving `nameserver localhost` (or `localhost.`) unchanged (can we assume that /etc/hosts and /etc/nsswitch.conf are well-configured?).
184	Quick question, if a user has: `options timeout:2 attempts:5 edns0`, according to the man page this should be accepted. More importantly, shouldn't we keep the other values as well?

des added inline comments.Jun 25 2026, 8:20 AM

usr.sbin/unbound/setup/local-unbound-setup.sh
83	That's not necessary, any unset or empty variable will evaluate to 0 in an arithmetic expression.
165–175	I no longer consider them valid. I considered removing them altogether but decided to just comment them out instead.
184	We do.

fix edns0 logic

Harbormaster completed remote builds in B74229: Diff 180598.Jun 25 2026, 9:01 AM

consistent style

Harbormaster completed remote builds in B74230: Diff 180599.Jun 25 2026, 9:02 AM

jlduran accepted this revision.Jun 25 2026, 9:38 AM

jlduran added inline comments.

usr.sbin/unbound/setup/local-unbound-setup.sh
2	?

This revision is now accepted and ready to land.Jun 25 2026, 9:38 AM

des added inline comments.Jun 25 2026, 10:27 AM

usr.sbin/unbound/setup/local-unbound-setup.sh
2	Apparently my Ctrl key is starting to fail...

rv

This revision now requires review to proceed.Jun 25 2026, 10:28 AM

Harbormaster completed remote builds in B74237: Diff 180609.Jun 25 2026, 10:28 AM

jlduran accepted this revision.Jun 25 2026, 5:06 PM

This revision is now accepted and ready to land.Jun 25 2026, 5:06 PM

Closed by commit rGf0a861efbafe: local-unbound-setup: Support IPv6-only systems (authored by des). · Explain WhyJun 26 2026, 2:43 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGf0a861efbafe: local-unbound-setup: Support IPv6-only systems.

des added a commit: rG973d1f2b12ab: local-unbound-setup: Support IPv6-only systems.Tue, Jul 7, 6:39 AM

des added a commit: rGba4033104a89: local-unbound-setup: Support IPv6-only systems.

Revision Contents
Changeset List

Path

Size

usr.sbin/

unbound/

setup/

local-unbound-setup.sh

50 lines

Diff 180593

usr.sbin/unbound/setup/local-unbound-setup.sh

Loading...