Page MenuHomeFreeBSD

libc: Fix ATOMIC_VAR_INIT visibility
ClosedPublic

Authored by des on Sun, Jun 21, 6:05 PM.
Tags
None
Referenced Files
F160452357: D57724.id180242.diff
Wed, Jun 24, 2:58 PM
F160441444: D57724.id.diff
Wed, Jun 24, 11:27 AM
F160424545: D57724.diff
Wed, Jun 24, 7:58 AM
F160412644: D57724.id180242.diff
Wed, Jun 24, 6:10 AM
F160378631: D57724.diff
Tue, Jun 23, 9:56 PM
F160375729: D57724.diff
Tue, Jun 23, 9:14 PM
Unknown Object (File)
Tue, Jun 23, 12:29 PM
Unknown Object (File)
Mon, Jun 22, 10:24 PM
Subscribers

Details

Summary

Fixes: 28cecfe27964 ("libc: Restrict ATOMIC_VAR_INIT for C23 conformance")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74082
Build 70965: arc lint + arc unit

Event Timeline

des requested review of this revision.Sun, Jun 21, 6:05 PM
des created this revision.

This looks sane, though I've only a minute to look at it before I have to stow my laptop for takeoff. We'll see if it works.

This revision is now accepted and ready to land.Sun, Jun 21, 6:11 PM
fuz added a subscriber: fuz.

Looks reasonable.

sys/sys/stdatomic.h
89

Now that I've had a chance to look at this, I'm convinced this is right because in the past __BSD_VISIBLE has meant 'also include obsoleted interfaces that a strict Cxx environment will have removed'. There's no great way to do this generically, and we'll need to remember this in code reviews. I missed this detail when I looked at it on github.

This revision was automatically updated to reflect the committed changes.