Page MenuHomeFreeBSD
Differential D57671

periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail
ClosedPublic
Actions

Authored by michaelo on Fri, Jun 19, 5:24 PM.
Tags
None
Referenced Files
F162638429: D57671.diff
Wed, Jul 15, 7:26 AM
F162638428: D57671.diff
Wed, Jul 15, 7:26 AM
Unknown Object (File)
Sat, Jul 11, 8:47 AM
Unknown Object (File)
Mon, Jul 6, 4:13 AM
Unknown Object (File)
Sun, Jul 5, 7:22 PM
Unknown Object (File)
Sat, Jul 4, 8:09 AM
Unknown Object (File)
Wed, Jul 1, 11:18 PM
Unknown Object (File)
Wed, Jul 1, 2:14 AM
View All 25 Files
Subscribers
imp
mail_fbsd2.e4m.org
ziaee

Details

Reviewers
jrm
Commits
rG1807800b7986: periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail
rG624e0bf29d72: periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail
rG6a7c8c922455: periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail
Summary

Introduce a new variable "security_status_loginfail_ignore" to filter unwanted
login failure messages from the daily security checks.

Co-authored-by: Michael Osipov <michaelo@FreeBSD.org>
PR: 295191
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michaelo created this revision.Fri, Jun 19, 5:24 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Jun 19, 5:24 PM
michaelo requested review of this revision.Fri, Jun 19, 5:24 PM
Harbormaster completed remote builds in B74012: Diff 180076.Fri, Jun 19, 5:24 PM
mail_fbsd2.e4m.org added a subscriber: mail_fbsd2.e4m.org.Sat, Jun 20, 4:55 AM
jrm added a comment.EditedSat, Jun 20, 7:14 PM

The commit message says "are no" instead of "are not". You might consider something simpler because users can really filter out whatever they want.

Introduce a new variable "security_status_loginfail_ignore" to filter unwanted login failure messages from the daily security checks.

share/man/man5/periodic.conf.5
1041–1043
  1. Rather than egrep(1), say extended regular expression, since egrep is deprecated in POSIX in favor of grep -E.
  2. Simplify the text. Users can really filter out whatever they want.
michaelo updated this revision to Diff 180195.Sat, Jun 20, 7:26 PM

@jrm, reasonable points. Thank you!

Harbormaster completed remote builds in B74068: Diff 180195.Sat, Jun 20, 7:26 PM
michaelo edited the summary of this revision. (Show Details)Sat, Jun 20, 7:26 PM
michaelo marked an inline comment as done.
jrm accepted this revision.Sat, Jun 20, 8:24 PM
This revision is now accepted and ready to land.Sat, Jun 20, 8:24 PM
Closed by commit rG6a7c8c922455: periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail (authored by mail_fbsd2.e4m.org, committed by michaelo). · Explain WhySat, Jun 20, 8:35 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: rG6a7c8c922455: periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail.
michaelo added a commit: rG624e0bf29d72: periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail.Sun, Jun 28, 8:19 PM
michaelo added a commit: rG1807800b7986: periodic/security: Introduce $security_status_loginfail_ignore for 800.loginfail.Sun, Jun 28, 8:22 PM

Revision Contents
Changeset List

PathSize
share/
man/
man5/
6 lines
usr.sbin/
periodic/
etc/
security/
1 line

Diff 180204

View Options

share/man/man5/periodic.conf.5

Loading...
View Options

usr.sbin/periodic/etc/security/800.loginfail

Loading...