Page MenuHomeFreeBSD
Differential D57683

Update dirdpes.mk et al
ClosedPublic
Actions

Authored by sjg on Fri, Jun 19, 8:05 PM.
Tags
None
Referenced Files
F160701451: D57683.diff
Fri, Jun 26, 11:07 PM
F160665414: D57683.id.diff
Fri, Jun 26, 2:50 PM
Unknown Object (File)
Thu, Jun 25, 9:17 PM
Unknown Object (File)
Thu, Jun 25, 8:38 AM
Unknown Object (File)
Wed, Jun 24, 8:11 AM
Unknown Object (File)
Wed, Jun 24, 7:38 AM
Unknown Object (File)
Wed, Jun 24, 7:37 AM
Unknown Object (File)
Wed, Jun 24, 4:32 AM
View All 9 Files
Subscribers
bdrewery
emaste
imp

Details

Reviewers
stevek
Commits
rG7386c0675c89: Update dirdpes.mk et al
Summary

Update to latest dirdeps related makefiles.

dirdeps.mk tweaks useful for universe among other corner cases.

	   also additional filtering for bogus paths ending in /

gendirdeps.mk allow more debugging

	   also additional filtering for bogus paths ending in /

install-new.mk fix bug when isPOSIX_SHELL is true

meta2deps.?? handle file names with spaces by ignoring them

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Errors
SeverityLocationCodeMessage
Errorshare/mk/meta2deps.py:52E101PEP8 E101
Errorshare/mk/meta2deps.py:54E101PEP8 E101
Errorshare/mk/meta2deps.py:55E101PEP8 E101
Errorshare/mk/meta2deps.py:71E402PEP8 E402
Errorshare/mk/meta2deps.py:72E402PEP8 E402
Errorshare/mk/meta2deps.py:73E402PEP8 E402
Errorshare/mk/meta2deps.py:74E402PEP8 E402
Errorshare/mk/meta2deps.py:76E302PEP8 E302
Errorshare/mk/meta2deps.py:78E101PEP8 E101
Errorshare/mk/meta2deps.py:107E231PEP8 E231
Errorshare/mk/meta2deps.py:120E302PEP8 E302
Errorshare/mk/meta2deps.py:141E302PEP8 E302
Errorshare/mk/meta2deps.py:154E129PEP8 E129
Errorshare/mk/meta2deps.py:158E302PEP8 E302
Errorshare/mk/meta2deps.py:172E302PEP8 E302
Errorshare/mk/meta2deps.py:178E302PEP8 E302
Errorshare/mk/meta2deps.py:191E302PEP8 E302
Errorshare/mk/meta2deps.py:267E713PEP8 E713
Errorshare/mk/meta2deps.py:272E713PEP8 E713
Errorshare/mk/meta2deps.py:289E713PEP8 E713
Errorshare/mk/meta2deps.py:294E713PEP8 E713
Errorshare/mk/meta2deps.py:319E231PEP8 E231
Errorshare/mk/meta2deps.py:332E501PEP8 E501
Errorshare/mk/meta2deps.py:366E501PEP8 E501
Warningshare/mk/meta2deps.py:42W191PEP8 W191
Unit
No Test Coverage
Build Status
Buildable 74027
Build 70910: arc lint + arc unit

Event Timeline

sjg created this revision.Fri, Jun 19, 8:05 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptFri, Jun 19, 8:05 PM
sjg requested review of this revision.Fri, Jun 19, 8:05 PM
Harbormaster completed remote builds in B74027: Diff 180098.Fri, Jun 19, 8:05 PM
stevek accepted this revision.Fri, Jun 19, 8:25 PM

Minor things in the python found by pep8, but the rest looks good.

This revision is now accepted and ready to land.Fri, Jun 19, 8:25 PM
sjg added a comment.Fri, Jun 19, 8:28 PM
In D57683#1322417, @stevek wrote:

Minor things in the python found by pep8, but the rest looks good.

Yes, ignoring those for now, as I don't know enough about pep8

This revision was landed with ongoing or failed builds.Fri, Jun 19, 8:30 PM
Closed by commit rG7386c0675c89: Update dirdpes.mk et al (authored by sjg). · Explain Why
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rG7386c0675c89: Update dirdpes.mk et al.

Revision Contents
Changeset List

PathSize
share/
mk/
28 lines
14 lines
4 lines
25 lines
15 lines

Diff 180098

View Options

share/mk/dirdeps.mk

Loading...
View Options

share/mk/gendirdeps.mk

Loading...
View Options

share/mk/install-new.mk

Loading...
View Options

share/mk/meta2deps.py

Loading...
View Options

share/mk/meta2deps.sh

Loading...