Page MenuHomeFreeBSD

etcupdate: Warn if the tree hasn't been built
Needs ReviewPublic

Authored by des on Mon, Jun 8, 4:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 21, 7:11 AM
Unknown Object (File)
Thu, Jun 18, 11:58 PM
Unknown Object (File)
Thu, Jun 18, 12:44 AM
Unknown Object (File)
Wed, Jun 17, 9:51 PM
Unknown Object (File)
Wed, Jun 17, 9:51 PM
Unknown Object (File)
Thu, Jun 11, 8:37 AM
Unknown Object (File)
Wed, Jun 10, 4:52 PM
Unknown Object (File)
Wed, Jun 10, 4:31 AM
Subscribers

Details

Reviewers
jhb
jrtc27
Summary

Warn the user before trying make installetc if etcupdate was invoked
without -b (or with -B) and it appears that make buildetc hasn't
already been run (which usually happens as part of make buildworld).

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73973
Build 70856: arc lint + arc unit

Event Timeline

des requested review of this revision.Mon, Jun 8, 4:38 PM
usr.sbin/etcupdate/etcupdate.sh
228

Should this bard fail instead of just being a warning?

1913

To avoid ambiguity with an output file that etcupdate build places into a tree.

des marked an inline comment as done.Thu, Jun 18, 1:22 PM
des added inline comments.
usr.sbin/etcupdate/etcupdate.sh
228

If one day the build stops producing the file we chose as a sentinel and nobody updates etcupdate, failing here would prevent etcupdate from running for no good reason. Not failing here, however, simply leads to failing in make installetc a little while later. Since the output goes to the log, the warning remains visible on the console when that happens.