Page MenuHomeFreeBSD
Differential D57595

asmc: Refactor sensor detection and sysctl registration
ClosedPublic
Actions

Authored by seuros on Jun 15 2026, 12:45 PM.
Tags
Referenced Files
F173863611: D57595.id179788.diff
Mon, Sep 28, 11:36 PM
F173859626: D57595.id180588.diff
Mon, Sep 28, 11:02 PM
F173801296: D57595.id.diff
Mon, Sep 28, 1:16 PM
Unknown Object (File)
Sat, Sep 26, 7:59 PM
Unknown Object (File)
Mon, Sep 21, 12:17 AM
Unknown Object (File)
Sat, Sep 19, 5:17 PM
Unknown Object (File)
Fri, Sep 18, 9:58 AM
Unknown Object (File)
Tue, Sep 15, 1:26 AM
View All 83 Files
Subscribers
imp

Details

Reviewers
adrian
ngie
Commits
rG5a7ff2eb7d0d: asmc: Refactor sensor detection and sysctl registration
rGc4595b2f9590: asmc: Refactor sensor detection and sysctl registration
rG104b311a03e4: asmc: Refactor sensor detection and sysctl registration
Summary

Replace repeated per-sensor-type blocks for voltage, current, power,
and ambient light sensors with table-driven loops.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73879
Build 70762: arc lint + arc unit

Event Timeline

seuros created this revision.Jun 15 2026, 12:45 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 15 2026, 12:45 PM
seuros requested review of this revision.Jun 15 2026, 12:45 PM
Harbormaster completed remote builds in B73879: Diff 179788.Jun 15 2026, 12:45 PM
seuros added projects: apple (x86), drivers.Jun 16 2026, 1:03 PM
adrian accepted this revision.Jun 23 2026, 11:05 PM
This revision is now accepted and ready to land.Jun 23 2026, 11:05 PM
ngie accepted this revision.Jun 24 2026, 6:20 PM
ngie added inline comments.
sys/dev/asmc/asmc.c
1735–1742

These are common units that can be abbreviated.
(not clang-format'ed).

Closed by commit rG104b311a03e4: asmc: Refactor sensor detection and sysctl registration (authored by seuros, committed by adrian). · Explain WhyJun 25 2026, 2:22 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG104b311a03e4: asmc: Refactor sensor detection and sysctl registration.
ngie added a commit: rGc4595b2f9590: asmc: Refactor sensor detection and sysctl registration.Fri, Sep 4, 11:09 PM
ngie added a commit: rG5a7ff2eb7d0d: asmc: Refactor sensor detection and sysctl registration.Sat, Sep 5, 11:33 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
asmc/
147 lines

Diff 179788

View Options

sys/dev/asmc/asmc.c

Loading...