callout: ddb: resolve symbol of callout function
ClosedPublic
Actions

Authored by bz on Wed, Jun 10, 12:05 PM.

Details

Reviewers

jhb
rlibby

Commits

rGb8ec4929e9f4: callout: ddb: resolve symbol of callout function

Summary

In the ddb show callout function try to resolve the symbol of the
callout function to improve debugging. In my case I went through
various callouts from show ktr to check what they were and this saved
me opening lldb/gdb next to it (and still having the old kernel as
the panic to debug was upon reboot).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 73799
Build 70682: arc lint + arc unit

Event Timeline

bz created this revision.Wed, Jun 10, 12:05 PM

Herald added subscribers: olce, imp. · View Herald TranscriptWed, Jun 10, 12:05 PM

bz requested review of this revision.Wed, Jun 10, 12:05 PM

Harbormaster completed remote builds in B73799: Diff 179556.Wed, Jun 10, 12:05 PM

Looks good. I presume you've tested it?

Just noting two points of consistency, though neither really matters:

You cast to db_addr_t, but the type of db_printsym off is db_expr_t, and _show_last_callout casts to db_expr_t. However I note that all other casts for db_printsym besides _show_last_callout cast to db_expr_t.
_show_last_callout doesn't add the parens like you do now for _show_callout. I prefer the parens.

This revision is now accepted and ready to land.Wed, Jun 10, 3:35 PM

Closed by commit rGb8ec4929e9f4: callout: ddb: resolve symbol of callout function (authored by bz). · Explain WhySun, Jun 14, 10:33 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGb8ec4929e9f4: callout: ddb: resolve symbol of callout function.