etcupdate: Warn if the tree hasn't been built
ClosedPublic
Actions

Authored by des on Mon, Jun 8, 4:38 PM.

Details

Reviewers

jhb
jrtc27

Commits

rG53a3d4760eb9: etcupdate: Warn if the tree hasn't been built

Summary

Warn the user before trying make installetc if etcupdate was invoked
without -b (or with -B) and it appears that make buildetc hasn't
already been run (which usually happens as part of make buildworld).

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73748
Build 70631: arc lint + arc unit

Event Timeline

des created this revision.Mon, Jun 8, 4:38 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jun 8, 4:38 PM

des requested review of this revision.Mon, Jun 8, 4:38 PM

Harbormaster completed remote builds in B73748: Diff 179395.Mon, Jun 8, 4:38 PM

jhb added inline comments.Thu, Jun 18, 1:08 PM

usr.sbin/etcupdate/etcupdate.sh
228	Should this bard fail instead of just being a warning?
1913	To avoid ambiguity with an output file that `etcupdate build` places into a tree.

des marked an inline comment as done.Thu, Jun 18, 1:22 PM

des added inline comments.

usr.sbin/etcupdate/etcupdate.sh
228	If one day the build stops producing the file we chose as a sentinel and nobody updates `etcupdate`, failing here would prevent `etcupdate` from running for no good reason. Not failing here, however, simply leads to failing in `make installetc` a little while later. Since the output goes to the log, the warning remains visible on the console when that happens.