Page MenuHomeFreeBSD
Differential D57495

fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path
AcceptedPublic
Actions

Authored by guest-seuros on Sun, Jun 7, 12:50 PM.
Tags
Referenced Files
F159331145: D57495.diff
Fri, Jun 12, 10:34 PM
Unknown Object (File)
Thu, Jun 11, 5:17 PM
Unknown Object (File)
Tue, Jun 9, 6:07 AM
Unknown Object (File)
Mon, Jun 8, 1:53 AM
Unknown Object (File)
Sun, Jun 7, 10:59 PM
Subscribers
None

Details

Reviewers
adrian
imp
ngie
zlei
Summary

M_PREPEND in the broadcast branch may call m_prepend(9) which allocates
a new head mbuf and calls m_move_pkthdr(), stripping M_PKTHDR from the
old mbuf.

xfer->mbuf was set before M_PREPEND, so it pointed at the
deheadered old mbuf. bus_dmamap_load_mbuf(9) asserts M_PKTHDR and
panics.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73733
Build 70616: arc lint + arc unit

Event Timeline

guest-seuros requested review of this revision.Sun, Jun 7, 12:50 PM
guest-seuros created this revision.
Harbormaster completed remote builds in B73733: Diff 179363.Sun, Jun 7, 12:50 PM
guest-seuros added projects: firewire, drivers.Sun, Jun 7, 3:17 PM
guest-seuros added a reviewer: zlei.Mon, Jun 8, 3:38 AM
adrian added a comment.Mon, Jun 8, 3:53 AM

oh good catch!

adrian accepted this revision.Mon, Jun 8, 3:54 AM
This revision is now accepted and ready to land.Mon, Jun 8, 3:54 AM
zlei accepted this revision.Mon, Jun 8, 6:45 AM

Looks sane to me.

sys/dev/firewire/if_fwip.c
602

So that we do not need the previous assignment xfer->mbuf = NULL.

666

A nit here.

zlei retitled this revision from fix(fwip): fix M_PKTHDR loss in fwip_async_output broadcast path to fwip: Fix M_PKTHDR loss in fwip_async_output broadcast path.Mon, Jun 8, 7:37 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
firewire/
22 lines

Diff 179363

View Options

sys/dev/firewire/if_fwip.c

Loading...