muge(4): Lock MII bus to fix link flaps
Needs ReviewPublic
Actions

Authored by rkitover_gmail.com on Sat, Jun 6, 1:57 PM.

Details

Reviewers

adrian
pouria
sanpei
zlei
kevlo
bms

Summary

Add a lock for MII bus operations and drop ticks if the lock is held to
work-around a race condition in the MII bus layer, see:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252165

. Tested with the EVB-LAN7800LC-1 MICROCHIP LAN7800 evaluation board.

This should fix Ethernet on the Raspberry Pi 3 and some other models
possibly.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73728
Build 70611: arc lint + arc unit

Event Timeline

rkitover_gmail.com created this revision.Sat, Jun 6, 1:57 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Jun 6, 1:57 PM

rkitover_gmail.com requested review of this revision.Sat, Jun 6, 1:57 PM

Harbormaster completed remote builds in B73727: Diff 179342.Sat, Jun 6, 1:57 PM

Add Differential Review link.

Harbormaster completed remote builds in B73728: Diff 179343.Sat, Jun 6, 2:00 PM

rkitover_gmail.com added reviewers: adrian, pouria, sanpei, zlei, kevlo, bms.Sat, Jun 6, 2:02 PM

rkitover_gmail.com added projects: USB, desktop.

rkitover_gmail.com mentioned this in D55631: axge: fix spurious link down from MII, frozen TX.Sat, Jun 6, 2:09 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

net/

if_muge.c

27 lines

Diff 179343

View Options

muge(4): Lock MII bus to fix link flapsNeeds ReviewPublicActions