Page MenuHomeFreeBSD
Differential D57410

sound: Adjust mmap example to use kqueue
Needs ReviewPublic
Actions

Authored by meka_tilda.center on Wed, Jun 3, 3:37 PM.
Tags
None
Referenced Files
F159071184: D57410.diff
Tue, Jun 9, 6:53 PM
Unknown Object (File)
Thu, Jun 4, 8:01 AM
Subscribers
imp
ziaee

Details

Reviewers
christos
Summary

With D57362 mmap is much easier and efficient to handle using kqueue, so mmap.c is change to reflect that.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

meka_tilda.center created this revision.Wed, Jun 3, 3:37 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptWed, Jun 3, 3:37 PM
meka_tilda.center requested review of this revision.Wed, Jun 3, 3:37 PM
meka_tilda.center updated this revision to Diff 179137.

In previous patch I acidently included kernel and map page patch, so this is a clean one.

meka_tilda.center added a parent revision: D57362: sound: Include more information in kevent returned from the kernel.Wed, Jun 3, 3:41 PM
christos added inline comments.Mon, Jun 8, 10:16 AM
share/examples/sound/mmap.c
46

Are all these needed here?

100

Can't we just re-use ev?

183

Should these be errx()s or warnx()s? In other words, are these fatal errors?

190–191

Revision Contents
Changeset List

PathSize
share/
examples/
sound/
187 lines

Diff 179137

View Options

share/examples/sound/mmap.c

Loading...