Page MenuHomeFreeBSD
Differential D57351

msun/logarithm_test: expect_fail log1p_accuracy_tests in the correct spot
ClosedPublic
Actions

Authored by siva on Fri, May 29, 9:53 PM.
Tags
None
Referenced Files
F160517102: D57351.diff
Thu, Jun 25, 7:14 AM
Unknown Object (File)
Wed, Jun 24, 11:51 AM
Unknown Object (File)
Wed, Jun 24, 5:41 AM
Unknown Object (File)
Fri, Jun 19, 8:08 PM
Unknown Object (File)
Wed, Jun 17, 11:59 PM
Unknown Object (File)
Tue, Jun 9, 2:29 AM
Unknown Object (File)
Tue, Jun 9, 2:26 AM
Unknown Object (File)
Mon, Jun 8, 5:16 AM
View All 16 Files
Subscribers
imp

Details

Reviewers
emaste
lwhsu
Commits
rG19af9c77acc9: msun/logarithm_test: expect_fail log1p_accuracy_tests in the correct spot
Summary

While here, remove the conditional on the "ci" config var to ensure that
this is reproducible locally as well.

This fixes a case where we are expecting a fail before the failing ATF_CHECK_*
assertion happens. Found in a CI failure here:
https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16608/testReport/lib.msun/logarithm_test/log1p_accuracy_tests/

PR: 253984
Fixes: 405188aeac540f7666dfde37c2f32d222119f56e

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73562
Build 70445: arc lint + arc unit

Event Timeline

siva created this revision.Fri, May 29, 9:53 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, May 29, 9:53 PM
siva requested review of this revision.Fri, May 29, 9:53 PM
Harbormaster completed remote builds in B73562: Diff 178953.Fri, May 29, 9:53 PM
siva added a comment.Wed, Jun 10, 11:27 PM

@lwhsu this is a quick fix, is it good to go?

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jun 17, 5:10 PM
Closed by commit rG19af9c77acc9: msun/logarithm_test: expect_fail log1p_accuracy_tests in the correct spot (authored by siva). · Explain Why
This revision was automatically updated to reflect the committed changes.
siva added a commit: rG19af9c77acc9: msun/logarithm_test: expect_fail log1p_accuracy_tests in the correct spot.

Revision Contents
Changeset List

PathSize
lib/
msun/
tests/
7 lines

Diff 178953

View Options

lib/msun/tests/logarithm_test.c

Loading...