Paths

Table of Contentst

Differential D57324

fts: Check link count before using it
ClosedPublic
Actions

Authored by des on Fri, May 29, 1:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jun 20, 3:27 PM

	Unknown Object (File)
	Sat, Jun 20, 1:11 PM

	Unknown Object (File)
	Wed, Jun 17, 8:27 PM

	Unknown Object (File)
	Tue, Jun 16, 1:16 PM

	Unknown Object (File)
	Sun, Jun 7, 12:15 AM

	Unknown Object (File)
	Sat, Jun 6, 10:41 PM

	Unknown Object (File)
	Sat, Jun 6, 8:36 PM

	Unknown Object (File)
	Sat, Jun 6, 6:17 PM

View All 18 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGe4dd3505c2d1: fts: Check link count before using it
rGb2b95249ae0e: fts: Check link count before using it

Summary

Check the range of the link count before trying to use it.

Rewrite the comment explaining what the link count is used for.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73544
Build 70427: arc lint + arc unit

Event Timeline

des created this revision.Fri, May 29, 1:24 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, May 29, 1:24 PM

des requested review of this revision.Fri, May 29, 1:24 PM

Harbormaster completed remote builds in B73540: Diff 178890.Fri, May 29, 1:24 PM

kevans added a subscriber: kevans.Fri, May 29, 2:16 PM

kevans added inline comments.

lib/libc/gen/fts.c
739	Pre-existing issue and a little pedantic, but this should probably at least be `long long` on FreeBSD to be correct for the remaining 32-bit arch we have? `__nlink_t` is unconditionally a `uint64_t`, so we have some range of values that might misbehave in presumably pathological cases. I probably would've gone with `nlink_t` and special-cased `(nlink_t)-1`, though. Losing one potential valid value for a link count seems fine, especially in light of your note that `NLINK_MAX` might be a truncated value anyways and we have to be conservative with it.

type

des marked an inline comment as done.Fri, May 29, 2:36 PM

Harbormaster completed remote builds in B73544: Diff 178895.Fri, May 29, 2:36 PM

I can dig it

This revision is now accepted and ready to land.Fri, May 29, 2:51 PM

Closed by commit rGb2b95249ae0e: fts: Check link count before using it (authored by des). · Explain WhyFri, May 29, 5:45 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGb2b95249ae0e: fts: Check link count before using it.

des added a commit: rGe4dd3505c2d1: fts: Check link count before using it.Thu, Jun 4, 2:41 PM

des mentioned this in D57461: (RFC) stdio: consolidate the two memstream implementations.Fri, Jun 5, 4:37 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

44 lines

Diff 178895

lib/libc/gen/fts.c

Loading...