Page MenuHomeFreeBSD
Differential D57461

(RFC) stdio: consolidate the two memstream implementations
Needs ReviewPublic
Actions

Authored by kevans on Fri, Jun 5, 1:09 AM.
Tags
None
Referenced Files
F159716424: D57461.id179249.diff
Wed, Jun 17, 10:48 AM
Unknown Object (File)
Sat, Jun 13, 12:26 PM
Unknown Object (File)
Wed, Jun 10, 10:29 PM
Unknown Object (File)
Wed, Jun 10, 6:20 PM
Unknown Object (File)
Wed, Jun 10, 6:30 AM
Unknown Object (File)
Tue, Jun 9, 7:10 PM
Subscribers
imp

Details

Reviewers
jhb
des
Group Reviewers
Klara
Summary

Substantial parts of the memstream and wmemstream implementations
overlap, and it's a little laborious to duplicate code between the two.

Abstract the differences out into some streamcfg structs and see if we
can get the arithmetic right and converge on a single implementation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73692
Build 70575: arc lint + arc unit

Event Timeline

kevans created this revision.Fri, Jun 5, 1:09 AM
Herald added a subscriber: imp. · View Herald TranscriptFri, Jun 5, 1:09 AM
kevans requested review of this revision.Fri, Jun 5, 1:09 AM
Harbormaster completed remote builds in B73692: Diff 179249.Fri, Jun 5, 1:09 AM
des added inline comments.Fri, Jun 5, 4:02 PM
lib/libc/stdio/open_memstream.c
97

is newoff here in bytes or in characters? I think the code might be easier to reason about if everything is in characters.

des added inline comments.Fri, Jun 5, 4:37 PM
lib/libc/stdio/open_memstream.c
47

See NLINK_MAX in D57324

Revision Contents
Changeset List

PathSize
lib/
libc/
stdio/
2 lines
244 lines

Diff 179249

View Options

lib/libc/stdio/Makefile.inc

Loading...
View Options

lib/libc/stdio/open_memstream.c

Loading...
View Options

lib/libc/stdio/open_wmemstream.c

Loading...