Page MenuHomeFreeBSD
Differential D57293

usb: Add missing mtx lock and unlock in pushing dma queue
ClosedPublic
Actions

Authored by aokblast on Thu, May 28, 9:08 AM.
Tags
Referenced Files
F160334165: D57293.diff
Tue, Jun 23, 9:48 AM
F160307064: D57293.id178797.diff
Tue, Jun 23, 2:43 AM
Unknown Object (File)
Sat, Jun 20, 6:13 PM
Unknown Object (File)
Sat, Jun 20, 1:20 PM
Unknown Object (File)
Mon, Jun 8, 11:31 AM
Unknown Object (File)
Mon, Jun 8, 11:21 AM
Unknown Object (File)
Mon, Jun 8, 3:04 AM
Unknown Object (File)
Mon, Jun 8, 3:01 AM
View All 24 Files
Subscribers
imp

Details

Reviewers
adrian
Group Reviewers
USB
Commits
rGe01b5034a627: usb: Add missing mtx lock and unlock in pushing dma queue
rG4f40c7c37fb4: usb: Add missing mtx lock and unlock in pushing dma queue
rGdf5e9e3da5b9: usb: Add missing mtx lock and unlock in pushing dma queue
Summary

Accessing usb_xfer_queue requires bus lock, we added this missing lock in here to prevent racing issue.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73506
Build 70389: arc lint + arc unit

Event Timeline

aokblast created this revision.Thu, May 28, 9:08 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, May 28, 9:08 AM
aokblast requested review of this revision.Thu, May 28, 9:08 AM
Harbormaster completed remote builds in B73498: Diff 178797.Thu, May 28, 9:08 AM
aokblast added reviewers: adrian, USB.Thu, May 28, 9:09 AM
aokblast added a project: USB.
aokblast updated this revision to Diff 178818.Thu, May 28, 12:43 PM

Refactor commit msg

Harbormaster completed remote builds in B73506: Diff 178818.Thu, May 28, 12:43 PM
aokblast edited the summary of this revision. (Show Details)Thu, May 28, 12:43 PM
adrian accepted this revision.Thu, May 28, 2:29 PM

nice catch! Why's this not panicing though? I thought I saw a lock assertion in usb_command_wrapper() ?

This revision is now accepted and ready to land.Thu, May 28, 2:29 PM
aokblast added a comment.Thu, May 28, 2:31 PM
In D57293#1312969, @adrian wrote:

nice catch! Why's this not panicing though? I thought I saw a lock assertion in usb_command_wrapper() ?

We don't have that now. This is found when I am trying to do so (do lock assertion in usb_command_wrapper).

Closed by commit rGdf5e9e3da5b9: usb: Add missing mtx lock and unlock in pushing dma queue (authored by aokblast). · Explain WhyThu, May 28, 2:38 PM
This revision was automatically updated to reflect the committed changes.
aokblast added a commit: rGdf5e9e3da5b9: usb: Add missing mtx lock and unlock in pushing dma queue.
aokblast added a commit: rG4f40c7c37fb4: usb: Add missing mtx lock and unlock in pushing dma queue.Tue, Jun 23, 8:53 PM
aokblast added a commit: rGe01b5034a627: usb: Add missing mtx lock and unlock in pushing dma queue.Tue, Jun 23, 8:57 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
2 lines

Diff 178818

View Options

sys/dev/usb/usb_transfer.c

Loading...