Differential D57293

usb: Add missing mtx lock and unlock in pushing dma queue
ClosedPublic
Actions

Authored by aokblast on Thu, May 28, 9:08 AM.

Details

Reviewers

adrian

Group Reviewers

USB

Commits

rGdf5e9e3da5b9: usb: Add missing mtx lock and unlock in pushing dma queue

Summary

Accessing usb_xfer_queue requires bus lock, we added this missing lock in here to prevent racing issue.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aokblast created this revision.Thu, May 28, 9:08 AM

Herald added a subscriber: imp. · View Herald TranscriptThu, May 28, 9:08 AM

aokblast requested review of this revision.Thu, May 28, 9:08 AM

Harbormaster completed remote builds in B73498: Diff 178797.Thu, May 28, 9:08 AM

aokblast added reviewers: adrian, USB.Thu, May 28, 9:09 AM

aokblast added a project: USB.

Refactor commit msg

Harbormaster completed remote builds in B73506: Diff 178818.Thu, May 28, 12:43 PM

aokblast edited the summary of this revision. (Show Details)Thu, May 28, 12:43 PM

nice catch! Why's this not panicing though? I thought I saw a lock assertion in usb_command_wrapper() ?

This revision is now accepted and ready to land.Thu, May 28, 2:29 PM

In D57293#1312969, @adrian wrote:

nice catch! Why's this not panicing though? I thought I saw a lock assertion in usb_command_wrapper() ?

We don't have that now. This is found when I am trying to do so (do lock assertion in usb_command_wrapper).

Closed by commit rGdf5e9e3da5b9: usb: Add missing mtx lock and unlock in pushing dma queue (authored by aokblast). · Explain WhyThu, May 28, 2:38 PM

This revision was automatically updated to reflect the committed changes.

aokblast added a commit: rGdf5e9e3da5b9: usb: Add missing mtx lock and unlock in pushing dma queue.

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

usb_transfer.c

2 lines

Diff 178824

View Options

sys/dev/usb/usb_transfer.c

usb: Add missing mtx lock and unlock in pushing dma queueClosedPublicActions